X-Git-Url: https://git.ozlabs.org/?p=ppp.git;a=blobdiff_plain;f=pppd%2Fplugins%2Fpppoe%2Fcommon.c;fp=pppd%2Fplugins%2Fpppoe%2Fcommon.c;h=9ddbcbd47f3202045c01141f9157f422840d77e8;hp=8b0e636acb800ab923a6b6c6d2cb3053448189f2;hb=ca75478c3e694d77c8af2fab1409346aafa1d9c5;hpb=032020241d270c53dff479a7b0eb7fe487c56a78

diff --git a/pppd/plugins/pppoe/common.c b/pppd/plugins/pppoe/common.c
index 8b0e636..9ddbcbd 100644
--- a/pppd/plugins/pppoe/common.c
+++ b/pppd/plugins/pppoe/common.c
@@ -28,6 +28,7 @@ static char const RCSID[] =
 #include <errno.h>
 #include <stdlib.h>
 #include <syslog.h>	/* for LOG_DEBUG */
+#include <ctype.h>
 
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
@@ -303,6 +304,15 @@ void pppoe_printpkt(PPPoEPacket *packet,
 	    printer(arg, "unknown tag 0x%x", tag);
 	}
 	if (tlen) {
+	    /* If it is supposed to be text, make sure it's all printing chars */
+	    if (text) {
+		for (j = 0; j < tlen; ++j) {
+		    if (!isprint(packet->payload[i+j])) {
+			text = 0;
+			break;
+		    }
+		}
+	    }
 	    if (text)
 		printer(arg, " %.*s", tlen, &packet->payload[i]);
 	    else {