From 90cd56cb816e7045b41542c119f64b9ee349a6bc Mon Sep 17 00:00:00 2001 From: Samuel Mendoza-Jonas Date: Fri, 18 Dec 2015 13:51:00 +1100 Subject: [PATCH] ui/common: Only close valid file descriptor Fixes Coverity defect #30466 Signed-off-by: Sam Mendoza-Jonas --- ui/common/joystick.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/common/joystick.c b/ui/common/joystick.c index 455ff19..a3d6abd 100644 --- a/ui/common/joystick.c +++ b/ui/common/joystick.c @@ -98,8 +98,8 @@ struct pjs *pjs_init(void *ctx, int (*map)(const struct js_event *)) return pjs; out_err: - close(pjs->fd); - pjs->fd = 0; + if (pjs->fd >= 0) + close(pjs->fd); talloc_free(pjs); return NULL; } -- 2.39.2