From: Jeremy Kerr <jk@ozlabs.org>
Date: Fri, 10 May 2013 02:47:24 +0000 (+0800)
Subject: discover: Always add a NUL byte to config data
X-Git-Tag: v1.0.0~637
X-Git-Url: https://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=7c8683fa009115f8a3b08b7a7666b64ebcbbc1bc

discover: Always add a NUL byte to config data

conf_get_pair will read one-byte past the end of the conf buffer, so
always NUL-terminate.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---

diff --git a/discover/parser.c b/discover/parser.c
index 11728b7..8d4c180 100644
--- a/discover/parser.c
+++ b/discover/parser.c
@@ -37,7 +37,7 @@ static int read_file(struct discover_context *ctx,
 	if (len > max_file_size)
 		goto err_close;
 
-	buf = talloc_array(ctx, char, len);
+	buf = talloc_array(ctx, char, len + 1);
 	if (!buf)
 		goto err_close;
 
@@ -55,6 +55,8 @@ static int read_file(struct discover_context *ctx,
 
 	}
 
+	buf[len] = '\0';
+
 	close(fd);
 	*bufp = buf;
 	*lenp = len;