From: Jeremy Kerr <jk@ozlabs.org>
Date: Mon, 16 Dec 2013 03:21:22 +0000 (+0800)
Subject: lib/util: Avoid sprintf in mac_str
X-Git-Tag: v1.0.0~285
X-Git-Url: https://git.ozlabs.org/?p=petitboot;a=commitdiff_plain;h=675d604772d99346e804b120c0c27cced985899a

lib/util: Avoid sprintf in mac_str

The conversion is simple, no need for sprintf.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---

diff --git a/lib/util/util.c b/lib/util/util.c
index 75b1c23..a18926c 100644
--- a/lib/util/util.c
+++ b/lib/util/util.c
@@ -15,12 +15,14 @@
  *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
-#include <stdio.h>
 #include <string.h>
 #include <assert.h>
 
 #include <util/util.h>
 
+static const char hex[] = { '0', '1', '2', '3', '4', '5', '6', '7',
+			    '8', '9', 'a', 'b', 'c', 'd', 'e', 'f', };
+
 void mac_str(uint8_t *mac, unsigned int maclen, char *buf, unsigned int buflen)
 {
 	unsigned int i;
@@ -36,8 +38,9 @@ void mac_str(uint8_t *mac, unsigned int maclen, char *buf, unsigned int buflen)
 	pos = buf;
 
 	for (i = 0; i < maclen; i++) {
-		snprintf(pos, 4, "%02x:", mac[i]);
-		pos += 3;
+		*(pos++) = hex[mac[i] >> 4 & 0xf];
+		*(pos++) = hex[mac[i] & 0xf];
+		*(pos++) = ':';
 	}
 
 	*(pos - 1) = '\0';