X-Git-Url: https://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fudev.c;h=28357c7e1b0b0441952aab16646ee1d1d67395c9;hp=bc0282749fe282521c15017dbff539a69527866c;hb=6b2d8ff75f1b9554d01dc6872b4498d660827e58;hpb=a58922346e06b827d4a81a33ce90f923dc103fde

diff --git a/discover/udev.c b/discover/udev.c
index bc02827..28357c7 100644
--- a/discover/udev.c
+++ b/discover/udev.c
@@ -1,17 +1,19 @@
 
 #define _GNU_SOURCE
 
-#include <stdlib.h>
+#include <errno.h>
 #include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
 #include <unistd.h>
-#include <errno.h>
-#include <sys/types.h>
 #include <sys/socket.h>
+#include <sys/types.h>
 #include <sys/un.h>
 
+#include <log/log.h>
 #include <talloc/talloc.h>
 #include <waiter/waiter.h>
-#include <log/log.h>
+#include <system/system.h>
 
 #include "event.h"
 #include "udev.h"
@@ -30,7 +32,12 @@ struct udev {
 static void udev_print_event(struct event *event)
 {
 	const char *action, *params[] = {
-		"DEVNAME", "ID_TYPE", "ID_BUS", "ID_FS_UUID", "ID_FS_LABEL",
+		"DEVNAME",
+		"DEVPATH",
+		"ID_TYPE",
+		"ID_BUS",
+		"ID_FS_UUID",
+		"ID_FS_LABEL",
 		NULL,
 	};
 	int i;
@@ -43,13 +50,13 @@ static void udev_print_event(struct event *event)
 	for (i = 0; params[i]; i++)
 		pb_log("\t%-12s => %s\n",
 				params[i], event_get_param(event, params[i]));
-
 }
 
 static void udev_handle_message(struct udev *udev, char *buf, int len)
 {
 	int result;
 	struct event *event;
+	const char *devpath;
 
 	event = talloc(udev, struct event);
 	event->type = EVENT_TYPE_UDEV;
@@ -62,7 +69,17 @@ static void udev_handle_message(struct udev *udev, char *buf, int len)
 		return;
 
 	udev_print_event(event);
-	device_handler_event(udev->handler, event);
+
+	/* Ignore ram, loop, and devices with no DEVNAME. */
+
+	devpath = event_get_param(event, "DEVPATH");
+
+	if (event_get_param(event, "DEVNAME")
+		&& !strstr(devpath, "virtual/block/loop")
+		&& !strstr(devpath, "virtual/block/ram")) {
+		device_handler_event(udev->handler, event);
+	}
+
 	talloc_free(event);
 
 	return;
@@ -118,6 +135,7 @@ struct udev *udev_init(struct device_handler *handler)
 
 	talloc_set_destructor(udev, udev_destructor);
 
+	memset(&addr, 0, sizeof addr);
 	addr.sun_family = AF_UNIX;
 	strcpy(addr.sun_path, PBOOT_DEVICE_SOCKET);
 
@@ -139,7 +157,16 @@ out_err:
 
 int udev_trigger(struct udev __attribute__((unused)) *udev)
 {
-	int rc = system("/sbin/udevadm trigger --subsystem-match=block --action=add");
+	const char *cmd[] = {
+		pb_system_apps.udevadm,
+		"trigger",
+		"--subsystem-match=block",
+		"--action=add",
+		NULL,
+	};
+	int rc;
+
+	rc = pb_run_cmd(cmd, 1, 0);
 
 	if (rc)
 		pb_log("udev trigger failed: %d (%d)\n", rc, WEXITSTATUS(rc));