X-Git-Url: https://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fdevice-handler.c;h=6a27f15780a5a4ae290e2ddf6d1b95f789dadb02;hp=12bc40f7283a83bf24dac77e3e4f0f353deb55af;hb=c62667e5c78ea212e5ac49244e9792954a1d8f71;hpb=7fed96b80c3e81ad73539c90310ab94166ff0229 diff --git a/discover/device-handler.c b/discover/device-handler.c index 12bc40f..6a27f15 100644 --- a/discover/device-handler.c +++ b/discover/device-handler.c @@ -10,7 +10,7 @@ #include #include #include -#include +#include #include #include "device-handler.h" @@ -19,10 +19,7 @@ #include "parser.h" #include "udev.h" #include "paths.h" - -#define MOUNT_BIN "/bin/mount" - -#define UMOUNT_BIN "/bin/umount" +#include "boot.h" struct device_handler { struct discover_server *server; @@ -33,11 +30,6 @@ struct device_handler { struct list contexts; }; -struct mount_map { - char *device_path; - char *mount_point; -}; - /** * device_handler_add - Add a device to the handler device array. */ @@ -194,23 +186,23 @@ static int mount_device(struct discover_context *ctx) pb_log("couldn't create mount directory %s: %s\n", ctx->mount_path, strerror(errno)); - argv[0] = MOUNT_BIN; + argv[0] = pb_system_apps.mount; argv[1] = ctx->device_path; argv[2] = ctx->mount_path; argv[3] = "-o"; argv[4] = "ro"; argv[5] = NULL; - if (pb_run_cmd(argv, 1)) { + if (pb_run_cmd(argv, 1, 0)) { /* Retry mount without ro option. */ - argv[0] = MOUNT_BIN; + argv[0] = pb_system_apps.mount; argv[1] = ctx->device_path; argv[2] = ctx->mount_path; argv[3] = NULL; - if (pb_run_cmd(argv, 1)) + if (pb_run_cmd(argv, 1, 0)) goto out_rmdir; } @@ -236,7 +228,8 @@ static int umount_device(struct discover_context *ctx) } if (pid == 0) { - execl(UMOUNT_BIN, UMOUNT_BIN, ctx->mount_path, NULL); + execl(pb_system_apps.umount, pb_system_apps.umount, + ctx->mount_path, NULL); exit(EXIT_FAILURE); } @@ -387,46 +380,31 @@ static int handle_remove_user_event(struct device_handler *handler, return 0; } +typedef int (*event_handler)(struct device_handler *, struct event *); + +static event_handler handlers[EVENT_TYPE_MAX][EVENT_ACTION_MAX] = { + [EVENT_TYPE_UDEV] = { + [EVENT_ACTION_ADD] = handle_add_udev_event, + [EVENT_ACTION_REMOVE] = handle_remove_udev_event, + }, + [EVENT_TYPE_USER] = { + [EVENT_ACTION_ADD] = handle_add_user_event, + [EVENT_ACTION_REMOVE] = handle_remove_user_event, + } +}; + int device_handler_event(struct device_handler *handler, struct event *event) { - int rc = 0; - - switch (event->type) { - case EVENT_TYPE_UDEV: - switch (event->action) { - case EVENT_ACTION_ADD: - rc = handle_add_udev_event(handler, event); - break; - case EVENT_ACTION_REMOVE: - rc = handle_remove_udev_event(handler, event); - break; - default: - pb_log("%s unknown action: %d\n", __func__, - event->action); - break; - } - break; - case EVENT_TYPE_USER: - switch (event->action) { - case EVENT_ACTION_ADD: - rc = handle_add_user_event(handler, event); - break; - case EVENT_ACTION_REMOVE: - rc = handle_remove_user_event(handler, event); - break; - default: - pb_log("%s unknown action: %d\n", __func__, - event->action); - break; - } - break; - default: - pb_log("%s unknown type: %d\n", __func__, event->type); - break; + if (event->type >= EVENT_TYPE_MAX || + event->action >= EVENT_ACTION_MAX || + !handlers[event->type][event->action]) { + pb_log("%s unknown type/action: %d/%d\n", __func__, + event->type, event->action); + return 0; } - return rc; + return handlers[event->type][event->action](handler, event); } struct device_handler *device_handler_init(struct discover_server *server) @@ -452,3 +430,30 @@ void device_handler_destroy(struct device_handler *handler) { talloc_free(handler); } + +static struct boot_option *find_boot_option_by_id( + struct device_handler *handler, const char *id) +{ + unsigned int i; + + for (i = 0; i < handler->n_devices; i++) { + struct device *dev = handler->devices[i]; + struct boot_option *opt; + + list_for_each_entry(&dev->boot_options, opt, list) + if (!strcmp(opt->id, id)) + return opt; + } + + return NULL; +} + +void device_handler_boot(struct device_handler *handler, + struct boot_command *cmd) +{ + struct boot_option *opt; + + opt = find_boot_option_by_id(handler, cmd->option_id); + + boot(handler, opt, cmd, 0); +}