X-Git-Url: https://git.ozlabs.org/?p=petitboot;a=blobdiff_plain;f=discover%2Fboot.c;h=313bd2af2de9b7e23de69309d8cac3b93dc8b8f2;hp=e7a72d4330c67d4586912cfb2e2c2994f3095203;hb=43b0a412efc1dfd8f2484a8b1e8aae11a855763c;hpb=4926cde5c97d09794ec33cca1321bb05a8d43304

diff --git a/discover/boot.c b/discover/boot.c
index e7a72d4..313bd2a 100644
--- a/discover/boot.c
+++ b/discover/boot.c
@@ -27,13 +27,25 @@ enum {
 	BOOT_HOOK_EXIT_UPDATE	= 2,
 };
 
+enum boot_process_state {
+	BOOT_STATE_INITIAL,
+	BOOT_STATE_IMAGE_LOADING,
+	BOOT_STATE_INITRD_LOADING,
+	BOOT_STATE_DTB_LOADING,
+	BOOT_STATE_FINISH,
+	BOOT_STATE_UNKNOWN,
+};
+
 
 struct boot_task {
 	char *local_image;
 	char *local_initrd;
 	char *local_dtb;
 	char *args;
-
+	struct pb_url *image, *initrd, *dtb;
+	boot_status_fn status_fn;
+	void *status_arg;
+	enum boot_process_state state;
 	bool dry_run;
 };
 
@@ -121,17 +133,23 @@ static int kexec_reboot(struct boot_task *task)
 	return result;
 }
 
-static void update_status(boot_status_fn fn, void *arg, int type,
-		char *message)
+static void __attribute__((format(__printf__, 4, 5))) update_status(
+		boot_status_fn fn, void *arg, int type, char *fmt, ...)
 {
 	struct boot_status status;
+	va_list ap;
+
+	va_start(ap, fmt);
+	status.message = talloc_vasprintf(NULL, fmt, ap);
+	va_end(ap);
 
 	status.type = type;
-	status.message = message;
 	status.progress = -1;
 	status.detail = NULL;
 
 	fn(arg, &status);
+
+	talloc_free(status.message);
 }
 
 static void boot_hook_update_param(void *ctx, struct boot_task *task,
@@ -210,8 +228,7 @@ static int hook_cmp(const struct dirent **a, const struct dirent **b)
 	return strcmp((*a)->d_name, (*b)->d_name);
 }
 
-static void run_boot_hooks(struct boot_task *task, boot_status_fn status_fn,
-		void *status_arg)
+static void run_boot_hooks(struct boot_task *task)
 {
 	struct dirent **hooks;
 	int i, n;
@@ -220,7 +237,7 @@ static void run_boot_hooks(struct boot_task *task, boot_status_fn status_fn,
 	if (n < 1)
 		return;
 
-	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+	update_status(task->status_fn, task->status_arg, BOOT_STATUS_INFO,
 			"running boot hooks");
 
 	boot_hook_setenv(task);
@@ -271,119 +288,188 @@ static void run_boot_hooks(struct boot_task *task, boot_status_fn status_fn,
 	free(hooks);
 }
 
-int boot(void *ctx, struct discover_boot_option *opt, struct boot_command *cmd,
-		int dry_run, boot_status_fn status_fn, void *status_arg)
+static void boot_process(void *ctx, int status)
 {
-	struct boot_task *boot_task;
-	struct pb_url *image, *initrd, *dtb;
+	struct boot_task *task = ctx;
 	unsigned int clean_image = 0;
 	unsigned int clean_initrd = 0;
 	unsigned int clean_dtb = 0;
-	int result;
-
-	image = NULL;
-	initrd = NULL;
-	dtb = NULL;
-
-	if (cmd && cmd->boot_image_file) {
-		image = pb_url_parse(opt, cmd->boot_image_file);
-	} else if (opt && opt->boot_image) {
-		image = opt->boot_image->url;
-	} else {
-		pb_log("%s: no image specified", __func__);
-		return -1;
-	}
-
-	boot_task = talloc_zero(ctx, struct boot_task);
-	boot_task->dry_run = dry_run;
-
-	if (cmd && cmd->initrd_file) {
-		initrd = pb_url_parse(opt, cmd->initrd_file);
-	} else if (opt && opt->initrd) {
-		initrd = opt->initrd->url;
-	}
-
-	if (cmd && cmd->dtb_file) {
-		dtb = pb_url_parse(opt, cmd->dtb_file);
-	} else if (opt && opt->dtb) {
-		dtb = opt->dtb->url;
-	}
-
-	if (cmd && cmd->boot_args) {
-		boot_task->args = talloc_strdup(boot_task, cmd->boot_args);
-	} else if (opt && opt->option->boot_args) {
-		boot_task->args = talloc_strdup(boot_task,
-						opt->option->boot_args);
-	} else {
-		boot_task->args = NULL;
+	int result = -1;
+
+	if (task->state == BOOT_STATE_INITIAL) {
+		update_status(task->status_fn, task->status_arg,
+				BOOT_STATUS_INFO, "loading kernel");
+		task->local_image = load_url_async(task, task->image,
+					&clean_image, boot_process);
+		if (!task->local_image) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Couldn't load kernel image");
+			goto no_load;
+		}
+		task->state = BOOT_STATE_IMAGE_LOADING;
+		return;
 	}
 
-	result = -1;
-
-	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-			"loading kernel");
-	boot_task->local_image = load_url(NULL, image, &clean_image);
-	if (!boot_task->local_image) {
-		update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-				"Couldn't load kernel image");
-		goto no_load;
+	if (task->state == BOOT_STATE_IMAGE_LOADING) {
+		if (status) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Error loading kernel image");
+			goto no_load;
+		}
+		task->state = BOOT_STATE_INITRD_LOADING;
+
+		if (task->initrd) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_INFO, "loading initrd");
+			task->local_initrd = load_url_async(task, task->initrd,
+					&clean_initrd, boot_process);
+			if (!task->local_initrd) {
+				update_status(task->status_fn, task->status_arg,
+						BOOT_STATUS_ERROR,
+						"Couldn't load initrd image");
+				goto no_load;
+			}
+			return;
+		}
 	}
 
-	if (initrd) {
-		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-				"loading initrd");
-		boot_task->local_initrd = load_url(NULL, initrd, &clean_initrd);
-		if (!boot_task->local_initrd) {
-			update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-					"Couldn't load initrd image");
+	if (task->state == BOOT_STATE_INITRD_LOADING) {
+		if (status) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Error loading initrd");
 			goto no_load;
 		}
+		task->state = BOOT_STATE_DTB_LOADING;
+
+		if (task->dtb) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_INFO,
+					"loading device tree");
+			task->local_dtb = load_url_async(task, task->dtb,
+						&clean_dtb, boot_process);
+			if (!task->local_dtb) {
+				update_status(task->status_fn, task->status_arg,
+						BOOT_STATUS_ERROR,
+						"Couldn't load device tree");
+				goto no_load;
+			}
+			return;
+		}
 	}
 
-	if (dtb) {
-		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
-				"loading device tree");
-		boot_task->local_dtb = load_url(NULL, dtb, &clean_dtb);
-		if (!boot_task->local_dtb) {
-			update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-					"Couldn't load device tree");
+	if (task->state == BOOT_STATE_DTB_LOADING) {
+		if (status) {
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
+					"Error loading dtb");
 			goto no_load;
 		}
+		task->state = BOOT_STATE_FINISH;
 	}
 
-	run_boot_hooks(boot_task, status_fn, status_arg);
 
-	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+	if (task->state != BOOT_STATE_FINISH) {
+		task->state = BOOT_STATE_UNKNOWN;
+		return;
+	}
+
+	run_boot_hooks(task);
+
+	update_status(task->status_fn, task->status_arg, BOOT_STATUS_INFO,
 			"performing kexec_load");
 
-	result = kexec_load(boot_task);
+	result = kexec_load(task);
 
 	if (result) {
-		update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
-				"kexec load failed");
+		update_status(task->status_fn, task->status_arg,
+				BOOT_STATUS_ERROR, "kexec load failed");
 	}
 
 no_load:
 	if (clean_image)
-		unlink(boot_task->local_image);
+		unlink(task->local_image);
 	if (clean_initrd)
-		unlink(boot_task->local_initrd);
+		unlink(task->local_initrd);
 	if (clean_dtb)
-		unlink(boot_task->local_dtb);
+		unlink(task->local_dtb);
 
 	if (!result) {
-		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+		update_status(task->status_fn, task->status_arg,
+				BOOT_STATUS_INFO,
 				"performing kexec reboot");
 
-		result = kexec_reboot(boot_task);
+		result = kexec_reboot(task);
 
 		if (result) {
-			update_status(status_fn, status_arg, BOOT_STATUS_ERROR,
+			update_status(task->status_fn, task->status_arg,
+					BOOT_STATUS_ERROR,
 					"kexec reboot failed");
 		}
 	}
 
-	talloc_free(boot_task);
+	talloc_free(task);
+}
 
-	return result;
+int boot(void *ctx, struct discover_boot_option *opt, struct boot_command *cmd,
+		int dry_run, boot_status_fn status_fn, void *status_arg)
+{
+	struct boot_task *boot_task;
+	struct pb_url *image = NULL;
+	const char *boot_desc;
+
+	if (opt && opt->option->name)
+		boot_desc = opt->option->name;
+	else if (cmd && cmd->boot_image_file)
+		boot_desc = cmd->boot_image_file;
+	else
+		boot_desc = "(unknown)";
+
+	update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+			"Booting %s.", boot_desc);
+
+	if (cmd && cmd->boot_image_file) {
+		image = pb_url_parse(opt, cmd->boot_image_file);
+	} else if (opt && opt->boot_image) {
+		image = opt->boot_image->url;
+	} else {
+		pb_log("%s: no image specified\n", __func__);
+		update_status(status_fn, status_arg, BOOT_STATUS_INFO,
+				"Boot failed: no image specified");
+		return -1;
+	}
+
+	boot_task = talloc_zero(ctx, struct boot_task);
+	boot_task->image = image;
+	boot_task->dry_run = dry_run;
+	boot_task->status_fn = status_fn;
+	boot_task->status_arg = status_arg;
+	boot_task->state = BOOT_STATE_INITIAL;
+
+	if (cmd && cmd->initrd_file) {
+		boot_task->initrd = pb_url_parse(opt, cmd->initrd_file);
+	} else if (opt && opt->initrd) {
+		boot_task->initrd = opt->initrd->url;
+	}
+
+	if (cmd && cmd->dtb_file) {
+		boot_task->dtb = pb_url_parse(opt, cmd->dtb_file);
+	} else if (opt && opt->dtb) {
+		boot_task->dtb = opt->dtb->url;
+	}
+
+	if (cmd && cmd->boot_args) {
+		boot_task->args = talloc_strdup(boot_task, cmd->boot_args);
+	} else if (opt && opt->option->boot_args) {
+		boot_task->args = talloc_strdup(boot_task,
+						opt->option->boot_args);
+	} else {
+		boot_task->args = NULL;
+	}
+
+	boot_process(boot_task, 0);
+
+	return 0;
 }