test/parser: Allow checks for NULL boot_args

[petitboot] / lib / pb-protocol / pb-protocol.c

diff --git a/lib/pb-protocol/pb-protocol.c b/lib/pb-protocol/pb-protocol.c
index d3174af7994cc8937fd1ca1df9d92948f0ba5238..681b250e20135ee334c0822a500eae0ea50f2973 100644 (file)
--- a/lib/pb-protocol/pb-protocol.c
+++ b/lib/pb-protocol/pb-protocol.c
@@ -22,6 +22,7 @@
  * action = 0x1: device add message
  *  payload:
  *   4-byte len, id
+ *   1-byte type
  *   4-byte len, name
  *   4-byte len, description
  *   4-byte len, icon_file
@@ -34,6 +35,7 @@
  *    4-byte len, icon_file
  *    4-byte len, boot_image_file
  *    4-byte len, initrd_file
+ *    4-byte len, dtb_file
  *    4-byte len, boot_args
  *
  * action = 0x2: device remove message
@@ -45,6 +47,7 @@
  *   4-byte len, boot option id
  *   4-byte len, boot_image_file
  *   4-byte len, initrd_file
+ *   4-byte len, dtb_file
  *   4-byte len, boot_args
  *
  */
@@ -67,6 +70,7 @@ void pb_protocol_dump_device(const struct device *dev, const char *text,
                fprintf(stream, "%s\t\ticon: %s\n", text, opt->icon_file);
                fprintf(stream, "%s\t\tboot: %s\n", text, opt->boot_image_file);
                fprintf(stream, "%s\t\tinit: %s\n", text, opt->initrd_file);
+               fprintf(stream, "%s\t\tdtb:  %s\n", text, opt->dtb_file);
                fprintf(stream, "%s\t\targs: %s\n", text, opt->boot_args);
        }
 }
@@ -163,6 +167,7 @@ static int optional_strlen(const char *str)
 int pb_protocol_device_len(const struct device *dev)
 {
        return  4 + optional_strlen(dev->id) +
+               sizeof(dev->type) +
                4 + optional_strlen(dev->name) +
                4 + optional_strlen(dev->description) +
                4 + optional_strlen(dev->icon_file);
@@ -178,6 +183,7 @@ int pb_protocol_boot_option_len(const struct boot_option *opt)
                4 + optional_strlen(opt->icon_file) +
                4 + optional_strlen(opt->boot_image_file) +
                4 + optional_strlen(opt->initrd_file) +
+               4 + optional_strlen(opt->dtb_file) +
                4 + optional_strlen(opt->boot_args) +
                sizeof(opt->is_default);
 }
@@ -187,6 +193,7 @@ int pb_protocol_boot_len(const struct boot_command *boot)
        return  4 + optional_strlen(boot->option_id) +
                4 + optional_strlen(boot->boot_image_file) +
                4 + optional_strlen(boot->initrd_file) +
+               4 + optional_strlen(boot->dtb_file) +
                4 + optional_strlen(boot->boot_args);
 }
 
@@ -204,6 +211,8 @@ int pb_protocol_serialise_device(const struct device *dev,
        char *pos = buf;
 
        pos += pb_protocol_serialise_string(pos, dev->id);
+       *(enum device_type *)pos = dev->type;
+       pos += sizeof(enum device_type);
        pos += pb_protocol_serialise_string(pos, dev->name);
        pos += pb_protocol_serialise_string(pos, dev->description);
        pos += pb_protocol_serialise_string(pos, dev->icon_file);
@@ -226,6 +235,7 @@ int pb_protocol_serialise_boot_option(const struct boot_option *opt,
        pos += pb_protocol_serialise_string(pos, opt->icon_file);
        pos += pb_protocol_serialise_string(pos, opt->boot_image_file);
        pos += pb_protocol_serialise_string(pos, opt->initrd_file);
+       pos += pb_protocol_serialise_string(pos, opt->dtb_file);
        pos += pb_protocol_serialise_string(pos, opt->boot_args);
 
        *(bool *)pos = opt->is_default;
@@ -245,6 +255,7 @@ int pb_protocol_serialise_boot_command(const struct boot_command *boot,
        pos += pb_protocol_serialise_string(pos, boot->option_id);
        pos += pb_protocol_serialise_string(pos, boot->boot_image_file);
        pos += pb_protocol_serialise_string(pos, boot->initrd_file);
+       pos += pb_protocol_serialise_string(pos, boot->dtb_file);
        pos += pb_protocol_serialise_string(pos, boot->boot_args);
 
        assert(pos <= buf + buf_len);
@@ -377,6 +388,12 @@ int pb_protocol_deserialise_device(struct device *dev,
        if (read_string(dev, &pos, &len, &dev->id))
                goto out;
 
+       if (len < sizeof(enum device_type))
+               goto out;
+       dev->type = *(enum device_type *)(pos);
+       pos += sizeof(enum device_type);
+       len -= sizeof(enum device_type);
+
        if (read_string(dev, &pos, &len, &dev->name))
                goto out;
 
@@ -423,6 +440,9 @@ int pb_protocol_deserialise_boot_option(struct boot_option *opt,
        if (read_string(opt, &pos, &len, &opt->initrd_file))
                goto out;
 
+       if (read_string(opt, &pos, &len, &opt->dtb_file))
+               goto out;
+
        if (read_string(opt, &pos, &len, &opt->boot_args))
                goto out;
 
@@ -455,6 +475,9 @@ int pb_protocol_deserialise_boot_command(struct boot_command *cmd,
        if (read_string(cmd, &pos, &len, &cmd->initrd_file))
                goto out;
 
+       if (read_string(cmd, &pos, &len, &cmd->dtb_file))
+               goto out;
+
        if (read_string(cmd, &pos, &len, &cmd->boot_args))
                goto out;