#include <talloc/talloc.h>
#include <waiter/waiter.h>
#include <system/system.h>
+#include <process/process.h>
#include "event.h"
#include "udev.h"
udev_list_entry_get_value(entry));
}
+/*
+ * Search for LVM logical volumes. If any exist they should be recognised
+ * by udev as normal.
+ * Normally this is handled in an init script, but on some platforms
+ * disks are slow enough to come up that we need to check again.
+ */
+static void lvm_vg_search(struct device_handler *handler)
+{
+ if (process_run_simple(handler, pb_system_apps.vgscan, "-qq", NULL))
+ pb_log("%s: Failed to execute vgscan\n", __func__);
+
+ if (process_run_simple(handler, pb_system_apps.vgchange, "-ay", "-qq",
+ NULL))
+ pb_log("%s: Failed to execute vgchange\n", __func__);
+}
+
static int udev_handle_block_add(struct pb_udev *udev, struct udev_device *dev,
const char *name)
{
+ char *devlinks = NULL, *link, *saveptr = NULL;
struct discover_device *ddev;
unsigned int i = 0;
const char *typestr;
const char *ignored_types[] = {
"linux_raid_member",
"swap",
- "LVM2_member",
NULL,
};
- bool cdrom;
+ bool cdrom, usb;
typestr = udev_device_get_devtype(dev);
if (!typestr) {
}
}
- /* If our environment's udev can recognise them explictly skip any
- * device mapper devices we encounter */
+ /* Ignore any device mapper devices that aren't logical volumes */
devname = udev_device_get_property_value(dev, "DM_NAME");
- if (devname) {
+ if (devname && ! udev_device_get_property_value(dev, "DM_LV_NAME")) {
pb_debug("SKIP: dm-device %s\n", devname);
return 0;
}
i++;
}
+ /* Search for LVM logical volumes if we see an LVM member */
+ if (strncmp(type, "LVM2_member", strlen("LVM2_member")) == 0) {
+ lvm_vg_search(udev->handler);
+ return 0;
+ }
+
/* We may see multipath devices; they'll have the same uuid as an
* existing device, so only parse the first. */
uuid = udev_device_get_property_value(dev, "ID_FS_UUID");
}
}
- ddev = discover_device_create(udev->handler, name);
+ /* Use DM_NAME for logical volumes, or the device name otherwise */
+ ddev = discover_device_create(udev->handler, uuid, devname ?: name);
+
+ if (devname) {
+ /*
+ * For logical volumes udev_device_get_devnode() returns a path
+ * of the form "/dev/dm-xx". These nodes names are not
+ * persistent and are opaque to the user. Instead use the more
+ * recognisable "/dev/mapper/lv-name" node if it is available.
+ */
+ devlinks = talloc_strdup(ddev,
+ udev_device_get_property_value(dev, "DEVLINKS"));
+ link = devlinks ? strtok_r(devlinks, " ", &saveptr) : NULL;
+ while (link) {
+ if (strncmp(link, "/dev/mapper/",
+ strlen("/dev/mapper/")) == 0) {
+ node = link;
+ break;
+ }
+ link = strtok_r(NULL, " ", &saveptr);
+ }
+ }
ddev->device_path = talloc_strdup(ddev, node);
+ talloc_free(devlinks);
if (uuid)
ddev->uuid = talloc_strdup(ddev, uuid);
prop = udev_device_get_property_value(dev, "ID_FS_LABEL");
if (prop)
ddev->label = talloc_strdup(ddev, prop);
- ddev->device->type = cdrom ? DEVICE_TYPE_OPTICAL : DEVICE_TYPE_DISK;
+
+ usb = !!udev_device_get_property_value(dev, "ID_USB_DRIVER");
+ if (cdrom)
+ ddev->device->type = DEVICE_TYPE_OPTICAL;
+ else
+ ddev->device->type = usb ? DEVICE_TYPE_USB : DEVICE_TYPE_DISK;
udev_setup_device_params(dev, ddev);
- /* Create a snapshot for all disks, unless it is an assembled RAID array */
- if (ddev->device->type == DEVICE_TYPE_DISK &&
- !udev_device_get_property_value(dev, "MD_LEVEL"))
+ /* Create a snapshot for all disk devices */
+ if ((ddev->device->type == DEVICE_TYPE_DISK ||
+ ddev->device->type == DEVICE_TYPE_USB))
devmapper_init_snapshot(udev->handler, ddev);
device_handler_discover(udev->handler, ddev);
struct udev_device *dev, struct discover_device *ddev)
{
const char *node;
+ bool eject = false;
node = udev_device_get_devnode(dev);
/* handle CDROM eject requests */
if (udev_device_get_property_value(dev, "DISK_EJECT_REQUEST")) {
- bool eject = false;
-
pb_debug("udev: eject request\n");
/* If the device is mounted, cdrom_id's own eject request may
if (ddev) {
eject = ddev->mounted;
udev_handle_dev_remove(udev, dev);
- return false;
}
if (eject)
return 0;
}
+#ifdef UDEV_LOGGING
static void udev_log_fn(struct udev __attribute__((unused)) *udev,
int __attribute__((unused)) priority, const char *file, int line,
const char *fn, const char *format, va_list args)
pb_log("libudev: %s %s:%d: ", fn, file, line);
vfprintf(pb_log_get_stream(), format, args);
}
+#endif
struct pb_udev *udev_init(struct device_handler *handler,
struct waitset *waitset)
udev_set_userdata(udev->udev, udev);
+#ifdef UDEV_LOGGING
udev_set_log_fn(udev->udev, udev_log_fn);
+#endif
result = udev_setup_monitor(udev->udev, &udev->monitor);
if (result)
projects / petitboot / blobdiff