pb-discover: Ignore ram, loop and no-name devices

[petitboot] / discover / udev.c

diff --git a/discover/udev.c b/discover/udev.c
index 1a527895878d4de36f17406c3fe7ad44c1ceb07d..a5d9e03006dd2af346a1418296526a47aece88ca 100644 (file)
--- a/discover/udev.c
+++ b/discover/udev.c
@@ -1,17 +1,18 @@
 
 #define _GNU_SOURCE
 
-#include <stdlib.h>
+#include <errno.h>
 #include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
 #include <unistd.h>
-#include <errno.h>
-#include <sys/types.h>
 #include <sys/socket.h>
+#include <sys/types.h>
 #include <sys/un.h>
 
+#include <log/log.h>
 #include <talloc/talloc.h>
 #include <waiter/waiter.h>
-#include <log/log.h>
 
 #include "event.h"
 #include "udev.h"
@@ -30,7 +31,12 @@ struct udev {
 static void udev_print_event(struct event *event)
 {
        const char *action, *params[] = {
-               "DEVNAME", "ID_TYPE", "ID_BUS", "ID_FS_UUID", "ID_FS_LABEL",
+               "DEVNAME",
+               "DEVPATH",
+               "ID_TYPE",
+               "ID_BUS",
+               "ID_FS_UUID",
+               "ID_FS_LABEL",
                NULL,
        };
        int i;
@@ -43,24 +49,36 @@ static void udev_print_event(struct event *event)
        for (i = 0; params[i]; i++)
                pb_log("\t%-12s => %s\n",
                                params[i], event_get_param(event, params[i]));
-
 }
 
 static void udev_handle_message(struct udev *udev, char *buf, int len)
 {
        int result;
        struct event *event;
+       const char *devpath;
 
        event = talloc(udev, struct event);
        event->type = EVENT_TYPE_UDEV;
 
+       pb_log("%s\n", buf);
+
        result = event_parse_ad_message(event, buf, len);
 
        if (result)
                return;
 
        udev_print_event(event);
-       device_handler_event(udev->handler, event);
+
+       /* Ignore ram, loop, and devices with no DEVNAME. */
+
+       devpath = event_get_param(event, "DEVPATH");
+
+       if (event_get_param(event, "DEVNAME")
+               && !strstr(devpath, "virtual/block/loop")
+               && !strstr(devpath, "virtual/block/ram")) {
+               device_handler_event(udev->handler, event);
+       }
+
        talloc_free(event);
 
        return;
@@ -116,6 +134,7 @@ struct udev *udev_init(struct device_handler *handler)
 
        talloc_set_destructor(udev, udev_destructor);
 
+       memset(&addr, 0, sizeof addr);
        addr.sun_family = AF_UNIX;
        strcpy(addr.sun_path, PBOOT_DEVICE_SOCKET);
 
@@ -137,7 +156,7 @@ out_err:
 
 int udev_trigger(struct udev __attribute__((unused)) *udev)
 {
-       int rc = system("/sbin/udevadm trigger --subsystem-match=block");
+       int rc = system("/sbin/udevadm trigger --subsystem-match=block --action=add");
 
        if (rc)
                pb_log("udev trigger failed: %d (%d)\n", rc, WEXITSTATUS(rc));