discover/file: Fix invalid free in replace_file

[petitboot] / discover / grub2 / script.c

diff --git a/discover/grub2/script.c b/discover/grub2/script.c
index d0b824aebcb9965e63d2ec0d0cb631da0a2dfc5d..2aaf1d3d2cb1495a63c48fe7d31f72882d921b52 100644 (file)
--- a/discover/grub2/script.c
+++ b/discover/grub2/script.c
@@ -23,8 +23,8 @@
        container_of(stmt, struct grub2_statement_conditional, st)
 
 struct env_entry {
-       const char              *name;
-       const char              *value;
+       char                    *name;
+       char                    *value;
        struct list_item        list;
 };
 
@@ -35,6 +35,8 @@ struct grub2_symtab_entry {
        struct list_item        list;
 };
 
+static const char *default_prefix = "/boot/grub";
+
 static struct grub2_symtab_entry *script_lookup_function(
                struct grub2_script *script, const char *name)
 {
@@ -73,11 +75,13 @@ void script_env_set(struct grub2_script *script,
 
        if (!entry) {
                entry = talloc(script, struct env_entry);
-               entry->name = name;
+               entry->name = talloc_strdup(entry, name);
                list_add(&script->environment, &entry->list);
+       } else {
+               talloc_free(entry->value);
        }
 
-       entry->value = value;
+       entry->value = talloc_strdup(entry, value);
 }
 
 static bool expand_var(struct grub2_script *script, struct grub2_word *word)
@@ -401,7 +405,7 @@ static void init_env(struct grub2_script *script)
 
        env = talloc(script, struct env_entry);
        env->name = talloc_strdup(env, "prefix");
-       env->value = talloc_strdup(env, "/");
+       env->value = talloc_strdup(env, default_prefix);
 
        list_add(&script->environment, &env->list);
 }