From 9cc7b245a9364893c96178a0dd987a62f96b5b41 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Andreas=20Bie=C3=9Fmann?= Date: Tue, 19 Nov 2013 15:44:01 +0100 Subject: [PATCH] tests/mboxviews: test for unchanged postscript MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Currently a patch containing postscript is always modified in patch_to_mbox() compared to the input patch. A comment containing 'some comment\n---\n some/file | 1 +' will be changed to 'some comment\n\n---\nsome/file | 1 +\n' which is annoying. This patch adds a test to detect that, a follow up patch will fix the error then. Signed-off-by: Andreas Bießmann Signed-off-by: Jeremy Kerr --- apps/patchwork/tests/test_mboxviews.py | 28 ++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/apps/patchwork/tests/test_mboxviews.py b/apps/patchwork/tests/test_mboxviews.py index 6209513..0e57f42 100644 --- a/apps/patchwork/tests/test_mboxviews.py +++ b/apps/patchwork/tests/test_mboxviews.py @@ -179,3 +179,31 @@ class MboxDateHeaderTest(TestCase): mail = email.message_from_string(response.content) mail_date = dateutil.parser.parse(mail['Date']) self.assertEqual(mail_date, date) + +class MboxCommentPostcriptUnchangedTest(TestCase): + """ Test that the mbox view doesn't change the postscript part of a mail. + There where always a missing blank right after the postscript + delimiter '---' and an additional newline right before. """ + def setUp(self): + defaults.project.save() + + self.person = defaults.patch_author_person + self.person.save() + + self.patch = Patch(project = defaults.project, + msgid = 'p1', name = 'testpatch', + submitter = self.person, content = '') + self.patch.save() + + self.txt = 'some comment\n---\n some/file | 1 +\n' + + comment = Comment(patch = self.patch, msgid = 'p1', + submitter = self.person, + content = self.txt) + comment.save() + + def testCommentUnchanged(self): + response = self.client.get('/patch/%d/mbox/' % self.patch.id) + self.assertContains(response, self.txt) + self.txt += "\n" + self.assertNotContains(response, self.txt) -- 2.39.2