Initial bundle reordering support

todo:
 * implement ajax reorder api
 * finish migration script
 * order patches in bundle view

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add per-user default filters to TODO

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[models] use case-insensitve lookup when creating confirmation

We were getting multiple entries when the case-sensitive lookup
failed.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add TODO

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use 'from' import for urlresolvers

Some python installs can't seem to find the fully-qualified module,
so use the 'from'-style import instead.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[models] Make patches unique on (msgid, project), not just (msgid)

On patchwork.ozlabs.org, we may see multiple patches for different
projects, but with the same message-id.

We want these patches to show up on both projects, so we need to change
the current UNIQUE contstraint on msgid.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Use standard UserAdmin for admin site

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Handle special case of "New newline at end of file"

If a file doesn't have a newline at the end, diff will insert a "\ No
newline at end of file" line in the middle of the last hunk. parser.py
was counting this line as part of the hunk line count. This had the side
effect of putting the last line of the hunk in the patch comment, and
truncating out the last line of the diff.

Handle this special case by not including this line in the internal line
counter. This appears to be the only case where diff will insert a
string like this within a hunk.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Handle patches with no content charset defined

If we don't have an incoming charset defined, assume utf-8.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Convert patch content to unicode before parsing

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[packages] Fix bug with django 1.0

We needed an extra to_field_name

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Accept x-diff patches

We should accept x-diff attachments as well as x-patch.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[packages] update to django 1.0

With a minor code change, and a small workaround.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[docs] Create python and packages directories

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[models] Fix exception on mbox view with non-ascii submitter name

We need to unicode the name instead of str-ing it.

Add test.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[sql] use separate grant-all scripts for postgresql and mysql

Mysql doesn't support granting to multiple tables, and requires a
different username format.

Would be nice to code the permissions somewhere, then generate the
grant statements as required.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[encoding] Don't output patch mbox as quoted-printable

git-am doesn't like quoted-printable, so output mbox files as raw 7- or
8-bit mbox files. This means we have to create a new MIMEText class, so
that the content isn't automatically QP-encoded on __init__().

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[models] Create patch mbox with utf-8 encoding

We were getting exceptions on the mbox view when looking at a
non-ascii patch.

Add test to suit.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[sql] Default data should be in fixtures, not custom SQL

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[tests] Remove print from SenderCorrelationTest

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[tests] Add tests for utf-8 patches

.. which expose a bug in the patch parser, so fix that.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Don't use bundle owner for current user

This made the top auth area show the bundle owner's details, not
the bundle owner's.

Bundle owner can still be accessed through bundle.owner in the template.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[html] Fix apparently-unclosed script tag

Firefox doesn't seem to grok the <script/> notation.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[html] Add select-all checkbox for patch lists

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[html] Reference common.js in base template

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[html] Consolidate js files

We don't need most of the stuff in htdocs/js/. Put the only function
required into a common.js, which we can add other stuff to.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Change default ordering to latest-first

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[css] Separate patchforms from list a little

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[html] Reinstate 'about' link

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[css] Remove horizontal scrollbar

We don't need to specify width on #title.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Restructure profile view, simplify bundle access

Make bundles more like todo lists - the list itself has its own page,
accessible from the top user links.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Fix empty bundle showing entire project's patches

If a bundle is empty, we end up triggering the 'if not patches' check
in generic_list(), which repopulates the patch list with the current
project's patches.

So, check for None instead, and leave the patch list empty.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add comment signoffs and acks to mbox text

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] Move helper functions into tests/utils.py

So that we can use them for other tests

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[models] Improve comment filter

We should be able to search on the patch_id faster.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Fix spacing for encoded headers

We need to join the fragments with a space.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Merge senders with different case

... and add tests

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] 2.4-ise test cases

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add bin/__init__.py

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Decode From: headers

We're getting a few utf-8 encoded From: addresses, so decode before
saving to the DB.

Also, add tests.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Don't remove --- update lines

We'd like to keep update lines in the patch comments, so change the
signature-removal code to allow them to pass through.

Also, add appropriate tests.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] Add test for signatures in comments

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] Add patchwork testing infrastructure

Add a small set of initial tests for the patch parsing code.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove superfluous print from parsemail.py

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix handling of newlines in subjects

By doing two passes of whitespace normalisation

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Drop project.linkname from patch subject lines

.. otherwise every cell patch will be prefixed with [Cbe-oss-dev]

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Improve [PATCH] subject parsing

We'd like to leave some fragments of [PATCH]-style headers in the
patch subject, so add functionality to do this in clean_subject

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add 404 template

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix 'activate' mispelling

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix mishandling of existing querystring parameters

Currently, we only get the first character of order= parameters
in the 'remove this filter' querystring.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remember state filter settings

We need to set a few 'selected' options..

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Don't apply delegate = Nobody filter by default

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Make state = Action Required a default filter

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add 'Action Required' meta-state filter

This filter shows all patches in states with action_required = True.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Save UserPersonConfirmations after activating

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Save confirmation object before trying to render user-link email

We need the key, which is generated in save()

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

pwclient: Get rid of underscore to dash replacement

I was erroneously doing some string substitutions so that it
would find project names with an underscore in the name.  It
was only necessary due to a side effect of a bug fixed in commit
35241d528c3699b982730a333e236d57dc6451b6 (find project by linkname,
not full name).  In my test case, I had an underscore in the linkname,
but a dash in the full name.

No such string replacement is necessary, and actually breaks
filtering by projects with an underscore in the name now that
we're searching by linkname properly.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Don't just rely on random for UserPersonConfirmation keys

It looks like we're getting identical keys generated for confirmation
keys. Problem has been reported to django, but in the meantime, salt
with the user and email details, then sha1 to give the final key.

This requires an increase in the field size for key, migration script
included.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add HashField.construct() method

To construct a new hash object for the given algorithm. While we're at
it, clean up the hashlib-wrapping code.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

xmlrpc: Fix Python 2.4 compatibility in _marshaled_dispatch

Based on an original patch from Nate Case <ncase@xes-inc.com>.

Python 24 doesn't accept encoding and allow_none fields for
xmlrpclib.dumps, so abstract this function at dispatcher init time.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Simplify hashlib behaviour in HashField

We only need to keep the size of the field required, not the
whole hashlib constructor

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Allow pwclient to accept patch hashes

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Make parser.py invokation a little more flexible

Add options to control output, allowing us to use the parser to
generate patch hashes.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Allow rehash for specific patches

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use hex strings for hash values

Binary strings a too hard to manage in DB queries and XMLRPC methods,
as we get all kinds of encoding issues.

Change HashField to use a hex string, and add a migration script for db
updates. The patches should be rehashed after migration.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add patch_get_by_hash method to XMLRPC interface

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Import hashlib in HashField.db_type

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Hook-up hashing infrastructure

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Move patchparser to patchwork.parser

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove unused parser.py file

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add commit_ref field to patch page

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Re-save user profile after setting name

This means we get Person objects created with the correct name, rather
than the username at time of creation.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Pass Authorization headers in fastcgi application

By default, mod_fcgi doens't allow the Authorization header, so
enable -pass-header, and handle the different header name in the
xmlrpc view

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix user/username mismatch on pwclientrc template

... and add a comment to the auth section

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use patchwork xmlrpc view in pwclientrc template

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix broken pwclient link

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Rename pwclient.py to pwclient

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add usage info for pwclient 'update' action

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Enable [auth] setion in pwclientrc template

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove django_xmlrpc from about page.

Since we don't use it.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add 'update' method to pwclient

This requires a new xmlrpc function, 'patch_set'. To do this, we
need HTTP Authentication support, which means changing to a custom
XMLRPC distpatcher that is aware of the Authorization: header.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use 'in' rather than '.count()'

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Make pwclient visible thorugh site, and add .pwclientrc infrastructure

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Set content-disposition header for pwclientrc

So that browsers will save, rather than view.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add pwclientrc configuration file sample for each project

This allows users to easily configure pwclient for a patchwork
instance.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use config file for pwclient settings

Add a ConfigParser-style config file for patchwork settings, rather
than the environment. At present, only the XMLRPC URL and current
project are included.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

xmlrpc: filter projects on linkname, not name

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add credit for djagno-xmlrpc app

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Only add /xmlrpc/ URL if ENABLE_XMLRPC is set.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add XML-RPC interface and command line client

Introduce a new XML-RPC Patchwork interface inspired by the SOAP
interface from the old Patchwork.  The interface itself is fairly
lightweight and generic, and provides read-only access to a limited
subset of the Patchwork database, along with server-side search
and flexible filtering capabilities.

The command line client is modeled after the old one with some
additional filtering options.

The XML-RPC interface is disabled by default.  You can enable it
by setting ENABLE_XMLRPC = True in local_settings.py

This feature uses the django-xmlrpc package available from
http://django-xmlrpc.googlecode.com.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

mod_python example configuration fixes

These fixes correct the example patchwork.mod_python.conf file to
actually work properly:

* Patchwork base directory needs to be in PythonPath so that
  things like "apps.urls" will import

* Set DJANGO_SETTINGS_MODULE to "settings" instead of
  "patchwork.settings" so that it can find the settings file to
  import

* Use LocationMatch instead of Location in order for the pattern
  matching to work (this was causing none of the images/stylesheets
  to be found when using mod_python)

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Show patch list checkboxes for all authenticated users

Although only some users can alter patches, others still need the
checkboxes to select patches to bundle.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use local settings module

This makes checkouts into a working patchwork site much easier.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

parsemail: Dynamically determine PATCHWORK_BASE

Remove hardcoded PATCHWORK_BASE in favor of determining it
relative to the script's location.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Exclude packages tree from separate .gitignore file

'cos it says so in the top-level .gitignore.

Also, this means that the lib/packages/ dir will be included in a git
checkout, which is helpful.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add top-level .gitignore file

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add delegate column

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add content-disposition: attachment header to bundle download

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove redundant 'Patchwork' from titles in registration templates

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use consistent icons for filter settings

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>