[html] Consolidate js files

We don't need most of the stuff in htdocs/js/. Put the only function
required into a common.js, which we can add other stuff to.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Change default ordering to latest-first

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[css] Separate patchforms from list a little

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[html] Reinstate 'about' link

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[css] Remove horizontal scrollbar

We don't need to specify width on #title.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Restructure profile view, simplify bundle access

Make bundles more like todo lists - the list itself has its own page,
accessible from the top user links.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[views] Fix empty bundle showing entire project's patches

If a bundle is empty, we end up triggering the 'if not patches' check
in generic_list(), which repopulates the patch list with the current
project's patches.

So, check for None instead, and leave the patch list empty.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add comment signoffs and acks to mbox text

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] Move helper functions into tests/utils.py

So that we can use them for other tests

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[models] Improve comment filter

We should be able to search on the patch_id faster.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Fix spacing for encoded headers

We need to join the fragments with a space.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Merge senders with different case

... and add tests

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] 2.4-ise test cases

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add bin/__init__.py

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Decode From: headers

We're getting a few utf-8 encoded From: addresses, so decode before
saving to the DB.

Also, add tests.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[parser] Don't remove --- update lines

We'd like to keep update lines in the patch comments, so change the
signature-removal code to allow them to pass through.

Also, add appropriate tests.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] Add test for signatures in comments

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

[test] Add patchwork testing infrastructure

Add a small set of initial tests for the patch parsing code.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove superfluous print from parsemail.py

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix handling of newlines in subjects

By doing two passes of whitespace normalisation

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Drop project.linkname from patch subject lines

.. otherwise every cell patch will be prefixed with [Cbe-oss-dev]

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Improve [PATCH] subject parsing

We'd like to leave some fragments of [PATCH]-style headers in the
patch subject, so add functionality to do this in clean_subject

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add 404 template

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix 'activate' mispelling

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix mishandling of existing querystring parameters

Currently, we only get the first character of order= parameters
in the 'remove this filter' querystring.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remember state filter settings

We need to set a few 'selected' options..

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Don't apply delegate = Nobody filter by default

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Make state = Action Required a default filter

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add 'Action Required' meta-state filter

This filter shows all patches in states with action_required = True.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Save UserPersonConfirmations after activating

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Save confirmation object before trying to render user-link email

We need the key, which is generated in save()

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

pwclient: Get rid of underscore to dash replacement

I was erroneously doing some string substitutions so that it
would find project names with an underscore in the name.  It
was only necessary due to a side effect of a bug fixed in commit
35241d528c3699b982730a333e236d57dc6451b6 (find project by linkname,
not full name).  In my test case, I had an underscore in the linkname,
but a dash in the full name.

No such string replacement is necessary, and actually breaks
filtering by projects with an underscore in the name now that
we're searching by linkname properly.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Don't just rely on random for UserPersonConfirmation keys

It looks like we're getting identical keys generated for confirmation
keys. Problem has been reported to django, but in the meantime, salt
with the user and email details, then sha1 to give the final key.

This requires an increase in the field size for key, migration script
included.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add HashField.construct() method

To construct a new hash object for the given algorithm. While we're at
it, clean up the hashlib-wrapping code.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

xmlrpc: Fix Python 2.4 compatibility in _marshaled_dispatch

Based on an original patch from Nate Case <ncase@xes-inc.com>.

Python 24 doesn't accept encoding and allow_none fields for
xmlrpclib.dumps, so abstract this function at dispatcher init time.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Simplify hashlib behaviour in HashField

We only need to keep the size of the field required, not the
whole hashlib constructor

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Allow pwclient to accept patch hashes

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Make parser.py invokation a little more flexible

Add options to control output, allowing us to use the parser to
generate patch hashes.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Allow rehash for specific patches

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use hex strings for hash values

Binary strings a too hard to manage in DB queries and XMLRPC methods,
as we get all kinds of encoding issues.

Change HashField to use a hex string, and add a migration script for db
updates. The patches should be rehashed after migration.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add patch_get_by_hash method to XMLRPC interface

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Import hashlib in HashField.db_type

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Hook-up hashing infrastructure

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Move patchparser to patchwork.parser

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove unused parser.py file

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add commit_ref field to patch page

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Re-save user profile after setting name

This means we get Person objects created with the correct name, rather
than the username at time of creation.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Pass Authorization headers in fastcgi application

By default, mod_fcgi doens't allow the Authorization header, so
enable -pass-header, and handle the different header name in the
xmlrpc view

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix user/username mismatch on pwclientrc template

... and add a comment to the auth section

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use patchwork xmlrpc view in pwclientrc template

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Fix broken pwclient link

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Rename pwclient.py to pwclient

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add usage info for pwclient 'update' action

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Enable [auth] setion in pwclientrc template

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove django_xmlrpc from about page.

Since we don't use it.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add 'update' method to pwclient

This requires a new xmlrpc function, 'patch_set'. To do this, we
need HTTP Authentication support, which means changing to a custom
XMLRPC distpatcher that is aware of the Authorization: header.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use 'in' rather than '.count()'

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Make pwclient visible thorugh site, and add .pwclientrc infrastructure

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Set content-disposition header for pwclientrc

So that browsers will save, rather than view.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add pwclientrc configuration file sample for each project

This allows users to easily configure pwclient for a patchwork
instance.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use config file for pwclient settings

Add a ConfigParser-style config file for patchwork settings, rather
than the environment. At present, only the XMLRPC URL and current
project are included.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

xmlrpc: filter projects on linkname, not name

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add credit for djagno-xmlrpc app

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Only add /xmlrpc/ URL if ENABLE_XMLRPC is set.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add XML-RPC interface and command line client

Introduce a new XML-RPC Patchwork interface inspired by the SOAP
interface from the old Patchwork.  The interface itself is fairly
lightweight and generic, and provides read-only access to a limited
subset of the Patchwork database, along with server-side search
and flexible filtering capabilities.

The command line client is modeled after the old one with some
additional filtering options.

The XML-RPC interface is disabled by default.  You can enable it
by setting ENABLE_XMLRPC = True in local_settings.py

This feature uses the django-xmlrpc package available from
http://django-xmlrpc.googlecode.com.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

mod_python example configuration fixes

These fixes correct the example patchwork.mod_python.conf file to
actually work properly:

* Patchwork base directory needs to be in PythonPath so that
  things like "apps.urls" will import

* Set DJANGO_SETTINGS_MODULE to "settings" instead of
  "patchwork.settings" so that it can find the settings file to
  import

* Use LocationMatch instead of Location in order for the pattern
  matching to work (this was causing none of the images/stylesheets
  to be found when using mod_python)

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Show patch list checkboxes for all authenticated users

Although only some users can alter patches, others still need the
checkboxes to select patches to bundle.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use local settings module

This makes checkouts into a working patchwork site much easier.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

parsemail: Dynamically determine PATCHWORK_BASE

Remove hardcoded PATCHWORK_BASE in favor of determining it
relative to the script's location.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Exclude packages tree from separate .gitignore file

'cos it says so in the top-level .gitignore.

Also, this means that the lib/packages/ dir will be included in a git
checkout, which is helpful.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add top-level .gitignore file

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add delegate column

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add content-disposition: attachment header to bundle download

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove redundant 'Patchwork' from titles in registration templates

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use consistent icons for filter settings

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove duplicate "- Patchwork" from patch page titles

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove bottom margin from title

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Remove 'action: ' print output

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use up/down arrows as sorting indicator

.. rather than a red heading, which implies an error.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Clean up stylesheet whitespace

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

parsemail.sh typo: Insert missing slash in path

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Python 2.4 exception printing compatibility

Use str(ex) instead of ex.message for reporting exceptions

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Support postgresql_psycopg2 DATABASE_ENGINE

Check for "postgresql*" rather than just "postgresql" in
HashField.db_type() so that postgresql_psycopg2 will work.

While we're here, raise an exception if the database engine is
unknown rather than silently not returning anything.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

In some places tabs are used instead of spaces for indentation,
even when other lines of a method are indented with spaces.

This gets rid of all tabs and uses spaces everywhere.

[Reworked to apply on newer code by Jeremy]

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add support for Python 2.4 email modules

Use email.MIMEText, email.Utils, and email.Header in the case
where importing the newer email.mime.text, email.utils, and
email.header modules failed.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Eliminate hashlib requirement

If the hashlib module does not exist, use sha and md5 modules instead
to support Python 2.4.  The hashlib module was added to Python 2.5.

Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add simple help infrastructure, with an 'about' page.

We'll need the about page for adding attribution for included
components.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use self.fields[field] rather than self.field when iterating form fields

This way, we included the delegate field added in the
MultiplePatchForm's constructor.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Patchform.delegate isn't required

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add padding before each project in 'other projects' lists

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Tone down acked-by and signed-off-by colours a little

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Zebra-stripe the patch list

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use DEFAULT_FROM_EMAIL rather than PATCHWORK_FROM_EMAIL

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add DB permissions for registration app

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Document dependency on django-registration

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Use django-registration infrastructure

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

No help for now.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Patchwork Beta 1.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add project argument to set_bundle

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Add project argument to set_patches

MultiplePatchForm needs a project, so pass one down.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>