From fdc6fb3dc948279469abe599fa616549e915d978 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Thu, 16 Jul 2009 11:29:16 +0930 Subject: [PATCH] Fix logic bug; we weren't checking last requirement in sort_deps. --- ccan/tdb/tools/replay_trace.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ccan/tdb/tools/replay_trace.c b/ccan/tdb/tools/replay_trace.c index bd4b8aa8..652af3a4 100644 --- a/ccan/tdb/tools/replay_trace.c +++ b/ccan/tdb/tools/replay_trace.c @@ -1088,6 +1088,10 @@ static bool sort_deps(char *filename[], struct op *op[], struct op *this_op; bool done[num_files]; + /* None left? We're sorted. */ + if (off == num) + return true; + /* Does this make serial numbers go backwards? Allow a little fuzz. */ if (off > 0) { int serial1 = op[res[off-1].file][res[off-1].op_num].serial; @@ -1102,10 +1106,6 @@ static bool sort_deps(char *filename[], struct op *op[], } } - /* One or none left? We're sorted. */ - if (off + 1 >= num) - return true; - memset(done, 0, sizeof(done)); /* Since ops within a trace file are ordered, we just need to figure -- 2.39.2