From cd90166506cb26fc0ed56c913265f490ff48f7cd Mon Sep 17 00:00:00 2001 From: David Gibson Date: Fri, 5 Oct 2012 00:12:27 +1000 Subject: [PATCH] rfc822: Rename bad-header test The run-bad-header.c test in the rfc822 module is actually testing handling of one specific sort of bad header - a header field which contains no colon character. Rename the test and its internal variables to better reflect this. Signed-off-by: David Gibson --- .../test/{run-bad-header.c => run-hdr-no-colon.c} | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) rename ccan/rfc822/test/{run-bad-header.c => run-hdr-no-colon.c} (84%) diff --git a/ccan/rfc822/test/run-bad-header.c b/ccan/rfc822/test/run-hdr-no-colon.c similarity index 84% rename from ccan/rfc822/test/run-bad-header.c rename to ccan/rfc822/test/run-hdr-no-colon.c index 27d76ec3..fcea7dc4 100644 --- a/ccan/rfc822/test/run-bad-header.c +++ b/ccan/rfc822/test/run-hdr-no-colon.c @@ -14,16 +14,16 @@ #include "testdata.h" #include "helper.h" -#define BAD_HEADER_STR "This is a bad header\n" -const char bad_header[] = +#define NO_COLON_STR "This is a bad header\n" +const char no_colon_msg[] = "Date: Tue, 22 Feb 2011 00:15:59 +1100\n" - BAD_HEADER_STR + NO_COLON_STR "From: Mister From \n" "To: Mizz To \n" "Subject: Some subject\n" "Message-ID: <20110221131559.GA28327@example>\n"; -static void test_bad_header(const char *buf, size_t len) +static void test_no_colon(const char *buf, size_t len) { struct rfc822_msg *msg; struct rfc822_header *hdr; @@ -50,7 +50,7 @@ static void test_bad_header(const char *buf, size_t len) hfull = rfc822_header_raw_content(msg, hdr); allocation_failure_check(); - ok(bytestring_eq(hfull, BYTESTRING(BAD_HEADER_STR)), + ok(bytestring_eq(hfull, BYTESTRING(NO_COLON_STR)), "Invalid header content"); rfc822_free(msg); @@ -61,7 +61,7 @@ int main(int argc, char *argv[]) { failtest_setup(argc, argv); - test_bad_header(bad_header, sizeof(bad_header)); + test_no_colon(no_colon_msg, sizeof(no_colon_msg)); /* This exits depending on whether all tests passed */ failtest_exit(exit_status()); -- 2.39.2