From 15290c3feb9b61967311659a865fb3b5d05b1a49 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Thu, 28 May 2009 13:34:27 +0930 Subject: [PATCH 1/1] Make ccanlint tests all positive: ie. "has _info.c file: FAILED". --- tools/ccanlint/Makefile | 2 +- tools/ccanlint/{no_info.c => has_info.c} | 12 ++++++------ tools/ccanlint/trailing_whitespace.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) rename tools/ccanlint/{no_info.c => has_info.c} (86%) diff --git a/tools/ccanlint/Makefile b/tools/ccanlint/Makefile index d236346f..87ff2d0e 100644 --- a/tools/ccanlint/Makefile +++ b/tools/ccanlint/Makefile @@ -1,4 +1,4 @@ -OBJS := tools/ccanlint/no_info.o \ +OBJS := tools/ccanlint/has_info.o \ tools/ccanlint/has_main_header.o \ tools/ccanlint/has_tests.o \ tools/ccanlint/trailing_whitespace.o \ diff --git a/tools/ccanlint/no_info.c b/tools/ccanlint/has_info.c similarity index 86% rename from tools/ccanlint/no_info.c rename to tools/ccanlint/has_info.c index 1ac925cf..563eb2f6 100644 --- a/tools/ccanlint/no_info.c +++ b/tools/ccanlint/has_info.c @@ -11,14 +11,14 @@ #include #include -static void *check_no_info(struct manifest *m) +static void *check_has_info(struct manifest *m) { if (m->info_file) return NULL; return m; } -static const char *describe_no_info(struct manifest *m, void *check_result) +static const char *describe_has_info(struct manifest *m, void *check_result) { return "You have no _info.c file.\n\n" "The file _info.c contains the metadata for a ccan package: things\n" @@ -70,9 +70,9 @@ static void create_info_template(struct manifest *m, void *check_result) fclose(info); } -struct ccanlint no_info = { - .name = "No _info.c file", - .check = check_no_info, - .describe = describe_no_info, +struct ccanlint has_info = { + .name = "Has _info.c file", + .check = check_has_info, + .describe = describe_has_info, .handle = create_info_template, }; diff --git a/tools/ccanlint/trailing_whitespace.c b/tools/ccanlint/trailing_whitespace.c index 537e955e..96ab0d9d 100644 --- a/tools/ccanlint/trailing_whitespace.c +++ b/tools/ccanlint/trailing_whitespace.c @@ -40,7 +40,7 @@ static const char *describe_trailing_whitespace(struct manifest *m, } struct ccanlint trailing_whitespace = { - .name = "Lines with unnecessary trailing whitespace", + .name = "No lines with unnecessary trailing whitespace", .total_score = 1, .check = check_trailing_whitespace, .describe = describe_trailing_whitespace, -- 2.39.2