From 04b63db616a482d6ed0f51a3ede8001415884bab Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Thu, 18 Jun 2015 13:00:01 +0930 Subject: [PATCH] ccanlint: handle circular test-depends. eg. asort depends on order, but order testdepends on asort. Probably not the greatest thing to do, but don't barf because of it. Reported-by: David Gibson Signed-off-by: Rusty Russell --- tools/ccanlint/tests/depends_exist.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/ccanlint/tests/depends_exist.c b/tools/ccanlint/tests/depends_exist.c index 09c187e9..f4d1e964 100644 --- a/tools/ccanlint/tests/depends_exist.c +++ b/tools/ccanlint/tests/depends_exist.c @@ -103,8 +103,11 @@ static void check_test_depends_exist(struct manifest *m, if (!strstarts(deps[i], "ccan/")) continue; - /* Don't add dependency twice: we can only be on one list! */ + /* Don't add dependency twice: we can only be on one list! + * Also, it's possible to have circular test depends, so drop + * self-refs. */ if (!have_dep(m, deps[i]) + && !streq(deps[i] + strlen("ccan/"), m->modname) && !add_dep(m, &m->test_deps, deps[i], score)) return; -- 2.39.2