From 05ec83512c478e03f0af460d304483ed292337d1 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Mon, 23 Aug 2021 16:10:10 +0930 Subject: [PATCH] tal: tal_dump() now prints to stderr. This is more widely available than stdout, which can interfere with other things. Signed-off-by: Rusty Russell --- ccan/tal/tal.c | 16 ++++++++-------- ccan/tal/tal.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ccan/tal/tal.c b/ccan/tal/tal.c index a4954111..fec47ac5 100644 --- a/ccan/tal/tal.c +++ b/ccan/tal/tal.c @@ -824,36 +824,36 @@ static void dump_node(unsigned int indent, const struct tal_hdr *t) const struct prop_hdr *p; for (i = 0; i < indent; i++) - printf(" "); - printf("%p len=%zu", t, t->bytelen); + fprintf(stderr, " "); + fprintf(stderr, "%p len=%zu", t, t->bytelen); for (p = t->prop; p; p = p->next) { struct children *c; struct name *n; struct notifier *no; if (is_literal(p)) { - printf(" \"%s\"", (const char *)p); + fprintf(stderr, " \"%s\"", (const char *)p); break; } switch (p->type) { case CHILDREN: c = (struct children *)p; - printf(" CHILDREN(%p):parent=%p,children={%p,%p}\n", + fprintf(stderr, " CHILDREN(%p):parent=%p,children={%p,%p}\n", p, c->parent, c->children.n.prev, c->children.n.next); break; case NAME: n = (struct name *)p; - printf(" NAME(%p):%s", p, n->name); + fprintf(stderr, " NAME(%p):%s", p, n->name); break; case NOTIFIER: no = (struct notifier *)p; - printf(" NOTIFIER(%p):fn=%p", p, no->u.notifyfn); + fprintf(stderr, " NOTIFIER(%p):fn=%p", p, no->u.notifyfn); break; default: - printf(" **UNKNOWN(%p):%i**", p, p->type); + fprintf(stderr, " **UNKNOWN(%p):%i**", p, p->type); } } - printf("\n"); + fprintf(stderr, "\n"); } static void tal_dump_(unsigned int level, const struct tal_hdr *t) diff --git a/ccan/tal/tal.h b/ccan/tal/tal.h index 20cd89c5..a3a15491 100644 --- a/ccan/tal/tal.h +++ b/ccan/tal/tal.h @@ -456,7 +456,7 @@ bool tal_check(const tal_t *ctx, const char *errorstr); #ifdef CCAN_TAL_DEBUG /** - * tal_dump - dump entire tal tree. + * tal_dump - dump entire tal tree to stderr. * * This is a helper for debugging tal itself, which dumps all the tal internal * state. -- 2.39.2