From: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon, 10 Nov 2014 04:30:06 +0000 (+1030)
Subject: ccanlint: check all headers for examples.
X-Git-Url: https://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=c5a49e4942e98f17744f2a50dead077b34d0ceaf

ccanlint: check all headers for examples.

pushpull module doesn't have examples in pushpull.h.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---

diff --git a/tools/ccanlint/tests/examples_exist.c b/tools/ccanlint/tests/examples_exist.c
index e308be20..c42a2e4e 100644
--- a/tools/ccanlint/tests/examples_exist.c
+++ b/tools/ccanlint/tests/examples_exist.c
@@ -79,13 +79,12 @@ static void extract_examples(struct manifest *m,
 		}
 	}
 
-	/* Check main header. */
+	/* Check all headers for examples. */
 	list_for_each(&m->h_files, f, list) {
-		if (!strstarts(f->name, m->basename)
-		    || strlen(f->name) != strlen(m->basename) + 2)
-			continue;
+		if (strstarts(f->name, m->basename)
+		    && strlen(f->name) == strlen(m->basename) + 2)
+			mainh = f;
 
-		mainh = f;
 		list_for_each(get_ccan_file_docs(f), d, list) {
 			if (streq(d->type, "example")) {
 				score->error = add_example(m, f, d);
@@ -115,7 +114,7 @@ struct ccanlint examples_exist = {
 	.key = "examples_exist",
 	.name = "_info and main header file have Example: sections",
 	.check = extract_examples,
-	.needs = "info_exists"
+	.needs = "info_exists main_header_exists"
 };
 
 REGISTER_TEST(examples_exist);