From: Kevin Locke Date: Fri, 23 Sep 2016 03:33:13 +0000 (-0600) Subject: configurator: Fix warning in HAVE_FOR_LOOP_DECLARATION X-Git-Url: https://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=c455d55526c0f15a8b54ecc7bbaf282b01c48ad0 configurator: Fix warning in HAVE_FOR_LOOP_DECLARATION Visual C++ prints "warning C4702: unreachable code" due to the return statement after the for loop which is never reached. Fix this by setting a variable returned by a single return statement at the end. Signed-off-by: Kevin Locke Signed-off-by: David Gibson --- diff --git a/tools/configurator/configurator.c b/tools/configurator/configurator.c index e9ff5ef1..75c59f86 100644 --- a/tools/configurator/configurator.c +++ b/tools/configurator/configurator.c @@ -202,8 +202,9 @@ static struct test tests[] = { " return sizeof(off_t) == 8 ? 0 : 1;\n" "}\n" }, { "HAVE_FOR_LOOP_DECLARATION", INSIDE_MAIN, NULL, NULL, - "for (int i = 0; i < argc; i++) { return 0; };\n" - "return 1;" }, + "int ret = 1;\n" + "for (int i = 0; i < argc; i++) { ret = 0; };\n" + "return ret;" }, { "HAVE_FLEXIBLE_ARRAY_MEMBER", OUTSIDE_MAIN, NULL, NULL, "struct foo { unsigned int x; int arr[]; };" }, { "HAVE_GETPAGESIZE", DEFINES_FUNC, NULL, NULL,