From: Douglas Bagnall <douglas@paradise.net.nz>
Date: Sat, 13 Aug 2011 12:19:59 +0000 (+0930)
Subject: opt: incidental comment and whitespace repair
X-Git-Url: https://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=babb23101ae447aefb65284b8f535f84e6a35008

opt: incidental comment and whitespace repair

This comment occurred in a couple of places:

 /* Set an integer value, various forms.  Sets to 1 on arg == NULL. */

One instance was clearly spurious, while the other was misleading.

Another resolution to this mismatch would be to add
"if (arg == NULL){*l = 1; return NULL}" somewhere, but I suspect
it may have been left out/removed because someone thought better.
---

diff --git a/ccan/opt/helpers.c b/ccan/opt/helpers.c
index 7022afbb..a27be22f 100644
--- a/ccan/opt/helpers.c
+++ b/ccan/opt/helpers.c
@@ -56,7 +56,8 @@ char *opt_set_charp(const char *arg, char **p)
 	return NULL;
 }
 
-/* Set an integer value, various forms.  Sets to 1 on arg == NULL. */
+/* Set an integer value, various forms.
+   FIXME: set to 1 on arg == NULL ? */
 char *opt_set_intval(const char *arg, int *i)
 {
 	long l;
@@ -102,7 +103,7 @@ char *opt_set_ulongval(const char *arg, unsigned long *ul)
 {
 	long int l;
 	char *err;
-	
+
 	err = opt_set_longval(arg, &l);
 	if (err)
 		return err;
@@ -153,7 +154,7 @@ void opt_show_charp(char buf[OPT_SHOW_LEN], char *const *p)
 		buf[2+len] = '\0';
 }
 
-/* Set an integer value, various forms.  Sets to 1 on arg == NULL. */
+/* Show an integer value, various forms. */
 void opt_show_intval(char buf[OPT_SHOW_LEN], const int *i)
 {
 	snprintf(buf, OPT_SHOW_LEN, "%i", *i);