From: Rusty Russell <rusty@rustcorp.com.au>
Date: Fri, 2 Sep 2011 06:18:17 +0000 (+0930)
Subject: tdb2: fix error handling for tdb1_transaction_commit.
X-Git-Url: https://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=b679512e4260b9847e2f846b07443e6907d8276f

tdb2: fix error handling for tdb1_transaction_commit.

tdb_repack() returns an enum TDB_ERROR, whereas
tdb1_transaction_commit is expected to return 0 or -1.
---

diff --git a/ccan/tdb2/tdb1_transaction.c b/ccan/tdb2/tdb1_transaction.c
index 6e39de33..157642a6 100644
--- a/ccan/tdb2/tdb1_transaction.c
+++ b/ccan/tdb2/tdb1_transaction.c
@@ -1174,7 +1174,8 @@ int tdb1_transaction_commit(struct tdb_context *tdb)
 	_tdb1_transaction_cancel(tdb);
 
 	if (need_repack) {
-		return tdb_repack(tdb);
+		if (tdb_repack(tdb) != 0)
+			return -1;
 	}
 
 	return 0;