From: Rusty Russell <rusty@rustcorp.com.au>
Date: Thu, 17 Mar 2011 11:42:22 +0000 (+1030)
Subject: ccanlint: don't ever used pre-built modules as dependencies.
X-Git-Url: https://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=a1d048552e7c9cbd07092cefb87204563a807608;ds=sidebyside

ccanlint: don't ever used pre-built modules as dependencies.

They're often out-of-date, and we're about to do special things to the
str module compile flags, so we don't *ever* want the default.

It doesn't add much to build times, and it eliminates a nasty source
of weird errors.
---

diff --git a/tools/ccanlint/compulsory_tests/depends_build.c b/tools/ccanlint/compulsory_tests/depends_build.c
index 00f75b37..8bce5544 100644
--- a/tools/ccanlint/compulsory_tests/depends_build.c
+++ b/tools/ccanlint/compulsory_tests/depends_build.c
@@ -53,7 +53,6 @@ static char *build_subdir_objs(struct manifest *m)
 char *build_submodule(struct manifest *m)
 {
 	char *errstr;
-	struct stat st;
 
 	if (m->compiled)
 		return NULL;
@@ -61,10 +60,6 @@ char *build_submodule(struct manifest *m)
 	if (!expect_obj_file(m))
 		return NULL;
 
-	m->compiled = talloc_asprintf(m, "%s.o", m->dir);
-	if (stat(m->compiled, &st) == 0)
-		return NULL;
-
 	if (verbose >= 2)
 		printf("  Building dependency %s\n", m->dir);