X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Fcompile.c;h=3ab1afaa3158cd44fa050da15892a355f476db6a;hp=8f80734b095d5ad06f0aec2f696b3197eaf0a4c2;hb=d2a4d6b49bc260bd0979965f4e4ef62b40b19efe;hpb=e73b0b37186b158369dc70652edae6706cba8133

diff --git a/tools/compile.c b/tools/compile.c
index 8f80734b..3ab1afaa 100644
--- a/tools/compile.c
+++ b/tools/compile.c
@@ -4,7 +4,7 @@
 
 bool compile_verbose = false;
 
-/* Compile multiple object files into a single.  Returns errmsg if fails. */
+/* Compile multiple object files into a single.  Returns NULL if fails. */
 char *link_objects(const void *ctx, const char *basename, bool in_pwd,
 		   const char *objs, char **errmsg)
 {
@@ -13,35 +13,34 @@ char *link_objects(const void *ctx, const char *basename, bool in_pwd,
 	if (compile_verbose)
 		printf("Linking objects into %s\n", file);
 
-	*errmsg = run_command(ctx, NULL, "ld -r -o %s %s", file, objs);
-	if (*errmsg) {
-		talloc_free(file);
-		return NULL;
-	}
-	return file;
+	if (run_command(ctx, NULL, errmsg, "ld -r -o %s %s", file, objs))
+		return file;
+
+	talloc_free(file);
+	return NULL;
 }
 
-/* Compile a single C file to an object file.  Returns errmsg if fails. */
-char *compile_object(const void *ctx, const char *cfile, const char *ccandir,
-		     const char *extra_cflags,
-		     const char *outfile)
+/* Compile a single C file to an object file. */
+bool compile_object(const void *ctx, const char *cfile, const char *ccandir,
+		    const char *extra_cflags,
+		    const char *outfile, char **output)
 {
 	if (compile_verbose)
 		printf("Compiling %s\n", outfile);
-	return run_command(ctx, NULL, CCAN_COMPILER " " CCAN_CFLAGS
+	return run_command(ctx, NULL, output, CCAN_COMPILER " " CCAN_CFLAGS
 			   " -I%s %s -c -o %s %s",
 			   ccandir, extra_cflags, outfile, cfile);
 }
 
 /* Compile and link single C file, with object files.
- * Returns error message or NULL on success. */
-char *compile_and_link(const void *ctx, const char *cfile, const char *ccandir,
-		       const char *objs, const char *extra_cflags,
-		       const char *libs, const char *outfile)
+ * Returns false on failure. */
+bool compile_and_link(const void *ctx, const char *cfile, const char *ccandir,
+		      const char *objs, const char *extra_cflags,
+		      const char *libs, const char *outfile, char **output)
 {
 	if (compile_verbose)
 		printf("Compiling and linking %s\n", outfile);
-	return run_command(ctx, NULL, CCAN_COMPILER " " CCAN_CFLAGS
+	return run_command(ctx, NULL, output, CCAN_COMPILER " " CCAN_CFLAGS
 			   " -I%s %s -o %s %s %s %s",
 			   ccandir, extra_cflags, outfile, cfile, objs, libs);
 }