X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Ftests_pass_without_features.c;h=15b161ef9c20a06f9e2bbfe22749cddd14ece7ed;hp=4ce337555b97f0274ca2e7697628faf684116545;hb=dfafd0a1f522277c9be5fc589885db38f706d108;hpb=b931f4765272d68de3b5e35d70c1933c27bcdea4

diff --git a/tools/ccanlint/tests/tests_pass_without_features.c b/tools/ccanlint/tests/tests_pass_without_features.c
index 4ce33755..15b161ef 100644
--- a/tools/ccanlint/tests/tests_pass_without_features.c
+++ b/tools/ccanlint/tests/tests_pass_without_features.c
@@ -1,6 +1,5 @@
 #include <tools/ccanlint/ccanlint.h>
 #include <tools/tools.h>
-#include <ccan/talloc/talloc.h>
 #include <ccan/str/str.h>
 #include <ccan/foreach/foreach.h>
 #include <sys/types.h>
@@ -17,7 +16,6 @@
 
 /* We don't do these under valgrind: too slow! */
 static void do_run_tests_no_features(struct manifest *m,
-				     bool keep,
 				     unsigned int *timeleft,
 				     struct score *score)
 {
@@ -29,6 +27,8 @@ static void do_run_tests_no_features(struct manifest *m,
 	foreach_ptr(list, &m->run_tests, &m->api_tests) {
 		list_for_each(list, i, list) {
 			score->total++;
+			if (verbose >= 2)
+				printf("   %s\n", i->name);
 			if (run_command(m, timeleft, &cmdout, "%s",
 					i->compiled[COMPILE_NOFEAT]))
 				score->score++;
@@ -54,11 +54,11 @@ static void run_under_debugger(struct manifest *m, struct score *score)
 	if (!ask("Should I run the first failing test under the debugger?"))
 		return;
 
-	command = talloc_asprintf(m, "gdb -ex 'break tap.c:139' -ex 'run' %s",
-				  first->file->compiled
-				  [COMPILE_NOFEAT]);
-	if (system(command))
+	command = tal_fmt(m, "gdb -ex 'break tap.c:139' -ex 'run' %s",
+			  first->file->compiled[COMPILE_NOFEAT]);
+	if (system(command)) {
 		doesnt_matter();
+	}
 }
 
 struct ccanlint tests_pass_without_features = {