X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Ftests_exist.c;h=048a5c3e0906ffcc91099b5bb0c9bd483aa38144;hp=64b2691e0eaceba570e0e7595cda0a543b3e134d;hb=77818c1729ed1dc68b7b99a6def6ac534a0da07c;hpb=7bb7cd58c2d9df126dd6072e5f3bec1eb4dc916b

diff --git a/tools/ccanlint/tests/tests_exist.c b/tools/ccanlint/tests/tests_exist.c
index 64b2691e..048a5c3e 100644
--- a/tools/ccanlint/tests/tests_exist.c
+++ b/tools/ccanlint/tests/tests_exist.c
@@ -10,7 +10,7 @@
 #include <err.h>
 #include <ccan/talloc/talloc.h>
 
-extern struct ccanlint tests_exist;
+REGISTER_TEST(tests_exist);
 
 static void handle_no_tests(struct manifest *m, struct score *score)
 {
@@ -104,6 +104,8 @@ static void check_tests_exist(struct manifest *m,
 		if (errno != ENOENT)
 			err(1, "statting %s", test_dir);
 		tests_exist.handle = handle_no_tests;
+		/* We "pass" this. */
+		score->pass = true;
 		return;
 	}
 
@@ -114,14 +116,11 @@ static void check_tests_exist(struct manifest *m,
 
 	if (list_empty(&m->api_tests)
 	    && list_empty(&m->run_tests)
-	    && list_empty(&m->compile_ok_tests)) {
-		if (list_empty(&m->compile_fail_tests)) {
-			score->error = talloc_strdup(score,
+	    && list_empty(&m->compile_ok_tests)
+	    && list_empty(&m->compile_fail_tests)) {
+		score->error = talloc_strdup(score,
 					     "No tests in test directory");
-			tests_exist.handle = handle_no_tests;
-		} else
-			score->error = talloc_strdup(score,
-				     "No positive tests in test directory");
+		tests_exist.handle = handle_no_tests;
 		return;
 	}
 	score->pass = true;
@@ -135,4 +134,3 @@ struct ccanlint tests_exist = {
 	.needs = ""
 };
 
-REGISTER_TEST(tests_exist);