X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Finfo_documentation_exists.c;h=c3f02226b869b5182c8fe49a76a9133c98bc9ddf;hp=93954c76df5612b87ea62974481d6ec47e28c60b;hb=1ddb7420f1ac53c060aec62e26702d1d7029fc54;hpb=38b87a97e4244e03d3f3887c0e632e31a0bfd8df diff --git a/tools/ccanlint/tests/info_documentation_exists.c b/tools/ccanlint/tests/info_documentation_exists.c index 93954c76..c3f02226 100644 --- a/tools/ccanlint/tests/info_documentation_exists.c +++ b/tools/ccanlint/tests/info_documentation_exists.c @@ -11,9 +11,8 @@ #include #include #include -#include #include -#include +#include static void check_info_documentation_exists(struct manifest *m, unsigned int *timeleft, @@ -26,7 +25,8 @@ static struct ccanlint info_documentation_exists = { .needs = "info_exists" }; -static void create_info_template_doc(struct manifest *m, struct score *score) +static void create_info_template_doc(struct manifest *m, + struct score *score UNNEEDED) { int fd; FILE *new; @@ -47,12 +47,12 @@ static void create_info_template_doc(struct manifest *m, struct score *score) " *\n" " * Followed by an Example: section with a standalone\n" " * (trivial and usually useless) program\n" - " */\n", m->basename, m->basename) < 0) { + " */\n", m->modname, m->basename) < 0) { unlink_noerr("_info.new"); err(1, "Writing to _info.new to insert documentation"); } - oldcontents = grab_file(m, m->info_file->fullname, NULL); + oldcontents = grab_file(m, m->info_file->fullname); if (!oldcontents) { unlink_noerr("_info.new"); err(1, "Reading %s", m->info_file->fullname); @@ -72,7 +72,7 @@ static void create_info_template_doc(struct manifest *m, struct score *score) } static void check_info_documentation_exists(struct manifest *m, - unsigned int *timeleft, + unsigned int *timeleft UNNEEDED, struct score *score) { struct list_head *infodocs = get_ccan_file_docs(m->info_file); @@ -83,7 +83,7 @@ static void check_info_documentation_exists(struct manifest *m, score->pass = true; list_for_each(infodocs, d, list) { - if (!streq(d->function, m->basename)) + if (!streq(d->function, m->modname)) continue; if (streq(d->type, "summary")) summary = true; @@ -94,13 +94,13 @@ static void check_info_documentation_exists(struct manifest *m, if (summary && description) { score->score = score->total; } else if (!summary) { - score->error = talloc_strdup(score, + score->error = tal_strdup(score, "_info file has no module documentation.\n\n" "CCAN modules use /**-style comments for documentation: the\n" "overall documentation belongs in the _info metafile.\n"); info_documentation_exists.handle = create_info_template_doc; } else if (!description) { - score->error = talloc_strdup(score, + score->error = tal_strdup(score, "_info file has no module description.\n\n" "The lines after the first summary line in the _info file\n" "documentation should describe the purpose and use of the\n"