X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Fdepends_accurate.c;fp=tools%2Fccanlint%2Ftests%2Fdepends_accurate.c;h=e2e8e8712a61876ecd74a77cc107165ce0578bf2;hp=05ada48a40dc8b829c361beca5ba9d17350abc6c;hb=dc8042b42500f79f613b1197df6cdf739615a89f;hpb=aabf300e324f7da5134d7ad45afba11225045c24 diff --git a/tools/ccanlint/tests/depends_accurate.c b/tools/ccanlint/tests/depends_accurate.c index 05ada48a..e2e8e871 100644 --- a/tools/ccanlint/tests/depends_accurate.c +++ b/tools/ccanlint/tests/depends_accurate.c @@ -1,8 +1,7 @@ #include #include -#include #include -#include +#include #include #include #include @@ -46,9 +45,9 @@ static bool check_dep_includes(struct manifest *m, for (i = 0; lines[i]; i++) { char *mod; - if (!strreg(f, lines[i], - "^[ \t]*#[ \t]*include[ \t]*[<\"]" - "(ccan/+.+)/+[^/]+\\.h", &mod)) + if (!tal_strreg(f, lines[i], + "^[ \t]*#[ \t]*include[ \t]*[<\"]" + "(ccan/+.+)/+[^/]+\\.h", &mod)) continue; if (has_dep(m, deps, used, mod)) @@ -86,10 +85,10 @@ static void check_depends_accurate(struct manifest *m, get_or_compile_info); } - core_deps = talloc_array_length(deps) - 1; - test_deps = talloc_array_length(tdeps) - 1; + core_deps = tal_count(deps) - 1; + test_deps = tal_count(tdeps) - 1; - used = talloc_zero_array(m, bool, core_deps + test_deps + 1); + used = tal_arrz(m, bool, core_deps + test_deps + 1); foreach_ptr(list, &m->c_files, &m->h_files) { struct ccan_file *f; @@ -105,10 +104,9 @@ static void check_depends_accurate(struct manifest *m, deps[i]); } - /* Now append test dependencies to deps. */ - deps = talloc_realloc(NULL, deps, char *, - (core_deps + test_deps + 1) * sizeof(char *)); - memcpy(&deps[core_deps], tdeps, test_deps * sizeof(char *)); + /* Now remove NUL and append test dependencies to deps. */ + deps = tal_dup(m, char *, take(deps), core_deps, test_deps + 2); + memcpy(deps + core_deps, tdeps, sizeof(tdeps[0]) * test_deps); /* ccan/tap is given a free pass. */ deps[core_deps + test_deps] = (char *)"ccan/tap"; deps[core_deps + test_deps + 1] = NULL;