X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=ccan%2Ftdb2%2Ftest%2Ffailtest_helper.c;h=f094a5974ea26c34a54474875d7c5c04b557ebeb;hp=f3ef09a6c3e84b33d0ca1807967505771835f17c;hb=3d99c9334fe3067c88772547b9c06acec21616ea;hpb=9571a41e8494f3135557e3ec50c2de856392173e;ds=sidebyside diff --git a/ccan/tdb2/test/failtest_helper.c b/ccan/tdb2/test/failtest_helper.c index f3ef09a6..f094a597 100644 --- a/ccan/tdb2/test/failtest_helper.c +++ b/ccan/tdb2/test/failtest_helper.c @@ -25,21 +25,6 @@ bool failmatch(const struct failtest_call *call, == '/'))); } -static const struct failtest_call * -find_repeat(const struct tlist_calls *history, - const struct failtest_call *call) -{ - const struct failtest_call *i; - - tlist_for_each(history, i, list) { - if (i != call) - continue; - if (failmatch(i, call->file, call->line, call->type)) - return i; - } - return NULL; -} - static bool is_nonblocking_lock(const struct failtest_call *call) { return call->type == FAILTEST_FCNTL && call->u.fcntl.cmd == F_SETLK; @@ -85,7 +70,7 @@ bool exit_check_log(struct tlist_calls *history) enum failtest_result block_repeat_failures(struct tlist_calls *history) { - const struct failtest_call *i, *last; + const struct failtest_call *last; last = tlist_tail(history, struct failtest_call, list); @@ -95,25 +80,12 @@ block_repeat_failures(struct tlist_calls *history) if (failmatch(last, INITIAL_TDB_MALLOC) || failmatch(last, URANDOM_OPEN) || failmatch(last, URANDOM_READ)) { - if (find_repeat(history, last)) - return FAIL_DONT_FAIL; return FAIL_PROBE; } /* Unlock or non-blocking lock is fail-once. */ - if (is_unlock(last)) { - /* Find a previous unlock at this point? */ - i = find_repeat(history, last); - if (i && is_unlock(i)) - return FAIL_DONT_FAIL; + if (is_unlock(last) || is_nonblocking_lock(last)) return FAIL_PROBE; - } else if (is_nonblocking_lock(last)) { - /* Find a previous non-blocking lock at this point? */ - i = find_repeat(history, last); - if (i && is_nonblocking_lock(i)) - return FAIL_DONT_FAIL; - return FAIL_PROBE; - } return FAIL_OK; }