X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=ccan%2Ftdb2%2Fhash.c;h=51874918c62ef4fb53e5581c252e8ace6301de9a;hp=dec7aae554acbd0f21fd10bf44c886ef72aae9ae;hb=c5e3f07a30056cb7c3c380bf690f80815ca4b6b1;hpb=b371060fb7e2aa6a5990413cabe5fcc5ba5cc84c diff --git a/ccan/tdb2/hash.c b/ccan/tdb2/hash.c index dec7aae5..51874918 100644 --- a/ccan/tdb2/hash.c +++ b/ccan/tdb2/hash.c @@ -129,6 +129,13 @@ bool is_subhash(tdb_off_t val) return val >> (64-TDB_OFF_UPPER_STEAL) == (1<home_bucket = use_bits(h, TDB_HASH_GROUP_BITS); - /* FIXME: Guess the depth, don't over-lock! */ - h->hlock_start = (tdb_off_t)group - << (64 - (TDB_TOPLEVEL_HASH_BITS - TDB_HASH_GROUP_BITS)); - h->hlock_range = 1ULL << (64 - (TDB_TOPLEVEL_HASH_BITS - - TDB_HASH_GROUP_BITS)); + h->hlock_start = hlock_range(group, &h->hlock_range); if (tdb_lock_hashes(tdb, h->hlock_start, h->hlock_range, ltype, TDB_LOCK_WAIT)) return TDB_OFF_ERR; @@ -610,3 +613,46 @@ int first_in_hash(struct tdb_context *tdb, int ltype, return next_in_hash(tdb, ltype, tinfo, kbuf, dlen); } + +/* Even if the entry isn't in this hash bucket, you'd have to lock this + * bucket to find it. */ +static int chainlock(struct tdb_context *tdb, const TDB_DATA *key, + int ltype, enum tdb_lock_flags waitflag, + const char *func) +{ + int ret; + uint64_t h = tdb_hash(tdb, key->dptr, key->dsize); + tdb_off_t lockstart, locksize; + unsigned int group, gbits; + + gbits = TDB_TOPLEVEL_HASH_BITS - TDB_HASH_GROUP_BITS; + group = bits(h, 64 - gbits, gbits); + + lockstart = hlock_range(group, &locksize); + + ret = tdb_lock_hashes(tdb, lockstart, locksize, ltype, waitflag); + tdb_trace_1rec(tdb, func, *key); + return ret; +} + +/* lock/unlock one hash chain. This is meant to be used to reduce + contention - it cannot guarantee how many records will be locked */ +int tdb_chainlock(struct tdb_context *tdb, TDB_DATA key) +{ + return chainlock(tdb, &key, F_WRLCK, TDB_LOCK_WAIT, "tdb_chainlock"); +} + +int tdb_chainunlock(struct tdb_context *tdb, TDB_DATA key) +{ + uint64_t h = tdb_hash(tdb, key.dptr, key.dsize); + tdb_off_t lockstart, locksize; + unsigned int group, gbits; + + gbits = TDB_TOPLEVEL_HASH_BITS - TDB_HASH_GROUP_BITS; + group = bits(h, 64 - gbits, gbits); + + lockstart = hlock_range(group, &locksize); + + tdb_trace_1rec(tdb, "tdb_chainunlock", key); + return tdb_unlock_hashes(tdb, lockstart, locksize, F_WRLCK); +}