X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=ccan%2Ftdb%2Ftest%2Fexternal-transaction.c;h=1211da9e76d5c1d54702f3725fc34e30eb8d9658;hp=c1442c215d6b0af3da35e4dff499c9b1c72cf6ae;hb=02b364ae6c3a120101aa1fd6eb0919994ca8ffb1;hpb=f83c45bf4ccd00d81498c30cf7455a9813cf104b

diff --git a/ccan/tdb/test/external-transaction.c b/ccan/tdb/test/external-transaction.c
index c1442c21..1211da9e 100644
--- a/ccan/tdb/test/external-transaction.c
+++ b/ccan/tdb/test/external-transaction.c
@@ -7,7 +7,9 @@
 #include <stdlib.h>
 #include <limits.h>
 #include <string.h>
+#include <errno.h>
 #include <ccan/tdb/tdb.h>
+#include <ccan/tap/tap.h>
 
 static volatile sig_atomic_t alarmed;
 static void do_alarm(int signum)
@@ -15,15 +17,22 @@ static void do_alarm(int signum)
 	alarmed++;
 }
 
-static int do_transaction(const char *name)
+static int do_operation(enum operation op, const char *name)
 {
 	TDB_DATA k = { .dptr = (void *)"a", .dsize = 1 };
 	TDB_DATA d = { .dptr = (void *)"b", .dsize = 1 };
-	struct tdb_context *tdb = tdb_open(name, 0, 0, O_RDWR, 0);
+	struct tdb_context *tdb;
 
+	tdb = tdb_open(name, 0, op == OPEN_WITH_CLEAR_IF_FIRST ?
+		       TDB_CLEAR_IF_FIRST : TDB_DEFAULT, O_RDWR, 0);
 	if (!tdb)
 		return -1;
 
+	if (op == OPEN || op == OPEN_WITH_CLEAR_IF_FIRST) {
+		tdb_close(tdb);
+		return 0;
+	}
+
 	alarmed = 0;
 	tdb_setalarm_sigptr(tdb, &alarmed);
 
@@ -51,28 +60,33 @@ maybe_alarmed:
 	return -3;
 }
 
+struct agent {
+	int cmdfd, responsefd;
+};
 
-/* Do this before doing any tdb stuff.  Return handle, or -1. */
-int prepare_external_agent(void)
+/* Do this before doing any tdb stuff.  Return handle, or NULL. */
+struct agent *prepare_external_agent(void)
 {
 	int pid;
 	int command[2], response[2];
 	struct sigaction act = { .sa_handler = do_alarm };
-	char name[PATH_MAX];
+	char name[1+PATH_MAX];
 
 	if (pipe(command) != 0 || pipe(response) != 0)
-		return -1;
+		return NULL;
 
 	pid = fork();
 	if (pid < 0)
-		return -1;
+		return NULL;
 
 	if (pid != 0) {
+		struct agent *agent = malloc(sizeof(*agent));
+
 		close(command[0]);
 		close(response[1]);
-		/* FIXME: Make fds consective. */
-		dup2(command[1]+1, response[1]);
-		return command[1];
+		agent->cmdfd = command[1];
+		agent->responsefd = response[0];
+		return agent;
 	}
 
 	close(command[1]);
@@ -80,7 +94,9 @@ int prepare_external_agent(void)
 	sigaction(SIGALRM, &act, NULL);
 
 	while (read(command[0], name, sizeof(name)) != 0) {
-		int result = do_transaction(name);
+		int result;
+
+		result = do_operation(name[0], name+1);
 		if (write(response[1], &result, sizeof(result))
 		    != sizeof(result))
 			err(1, "Writing response");
@@ -88,16 +104,20 @@ int prepare_external_agent(void)
 	exit(0);
 }
 
-/* Ask the external agent to try to do a transaction. */
-bool external_agent_transaction(int handle, const char *tdbname)
+/* Ask the external agent to try to do an operation. */
+bool external_agent_operation(struct agent *agent,
+			      enum operation op, const char *tdbname)
 {
 	int res;
+	char string[1 + strlen(tdbname) + 1];
+
+	string[0] = op;
+	strcpy(string+1, tdbname);
 
-	if (write(handle, tdbname, strlen(tdbname)+1)
-	    != strlen(tdbname)+1)
+	if (write(agent->cmdfd, string, sizeof(string)) != sizeof(string))
 		err(1, "Writing to agent");
 
-	if (read(handle+1, &res, sizeof(res)) != sizeof(res))
+	if (read(agent->responsefd, &res, sizeof(res)) != sizeof(res))
 		err(1, "Reading from agent");
 
 	if (res > 1)
@@ -105,3 +125,41 @@ bool external_agent_transaction(int handle, const char *tdbname)
 
 	return res;
 }
+
+void external_agent_operation_start(struct agent *agent,
+				    enum operation op, const char *tdbname)
+{
+	char string[1 + strlen(tdbname) + 1];
+
+	string[0] = op;
+	strcpy(string+1, tdbname);
+
+	if (write(agent->cmdfd, string, sizeof(string)) != sizeof(string))
+		err(1, "Writing to agent");
+}
+
+bool external_agent_operation_check(struct agent *agent, bool block, int *res)
+{
+	int flags = fcntl(agent->responsefd, F_GETFL);
+
+	if (block)
+		fcntl(agent->responsefd, F_SETFL, flags & ~O_NONBLOCK);
+	else
+		fcntl(agent->responsefd, F_SETFL, flags | O_NONBLOCK);
+
+	switch (read(agent->responsefd, res, sizeof(*res))) {
+	case sizeof(*res):
+		break;
+	case 0:
+		errx(1, "Agent died?");
+	default:
+		if (!block && (errno == EAGAIN || errno == EWOULDBLOCK))
+			return false;
+		err(1, "%slocking reading from agent", block ? "B" : "Non-b");
+	}
+
+	if (*res > 1)
+		errx(1, "Agent returned %u\n", *res);
+
+	return true;
+}