X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=ccan%2Ftdb%2Fopen.c;h=0292920c11b4d565c1f4df9c1b7c032cea995d54;hp=69885284c55d6abfce78b4d15d9b126a442d8ea1;hb=43ae196c43d739ee06dbe31e0032f1b5fe811e3b;hpb=3c81225fc0a4fb99d10282ebf11b7ec6ae1eabdd diff --git a/ccan/tdb/open.c b/ccan/tdb/open.c index 69885284..0292920c 100644 --- a/ccan/tdb/open.c +++ b/ccan/tdb/open.c @@ -324,11 +324,12 @@ struct tdb_context *tdb_open_ex(const char *name, int hash_size, int tdb_flags, sprintf(tracefile, "%s.trace.%u", name, getpid()); tdb->tracefd = open(tracefile, O_WRONLY|O_CREAT|O_EXCL, 0600); - if (tdb->tracefd < 0) - goto fail; - tdb_enable_seqnum(tdb); - tdb_trace_open(tdb, "tdb_open", hash_size, tdb_flags, - open_flags); + if (tdb->tracefd >= 0) { + tdb_enable_seqnum(tdb); + tdb_trace_open(tdb, "tdb_open", hash_size, tdb_flags, + open_flags); + } else + TDB_LOG((tdb, TDB_DEBUG_ERROR, "tdb_open_ex: failed to open trace file %s!\n", tracefile)); } #endif @@ -348,8 +349,9 @@ struct tdb_context *tdb_open_ex(const char *name, int hash_size, int tdb_flags, if (!tdb) return NULL; +#ifdef TDB_TRACE close(tdb->tracefd); - +#endif if (tdb->map_ptr) { if (tdb->flags & TDB_INTERNAL) SAFE_FREE(tdb->map_ptr); @@ -409,7 +411,9 @@ int tdb_close(struct tdb_context *tdb) } } +#ifdef TDB_TRACE close(tdb->tracefd); +#endif memset(tdb, 0, sizeof(*tdb)); SAFE_FREE(tdb);