X-Git-Url: https://git.ozlabs.org/?p=ccan;a=blobdiff_plain;f=ccan%2Ftally%2Ftally.c;h=774373ca0f88e0b4a48bed5029107cf28bded0d1;hp=9775cb4e62a3087e070cf9cd28dab8f4b7e051af;hb=0eb0295702246b0b1b273f019a3b7a3d0600dd22;hpb=9dba5bf0cb3f74bf9bcaebd8c63ceaa8c6dcbbab

diff --git a/ccan/tally/tally.c b/ccan/tally/tally.c
index 9775cb4e..774373ca 100644
--- a/ccan/tally/tally.c
+++ b/ccan/tally/tally.c
@@ -302,8 +302,9 @@ static int64_t divls64(int64_t u1, uint64_t u0, int64_t v)
 	vneg = v >> 63;		  /* -1 if v < 0. */
 	v = (v ^ vneg) - vneg;	  /* Absolute value of v. */
 
-	if ((uint64_t)u1 >= (uint64_t)v)
+	if ((uint64_t)u1 >= (uint64_t)v) {
 		goto overflow;
+	}
 
 	q = divlu64(u1, u0, v);
 
@@ -321,8 +322,9 @@ static int64_t divls64(int64_t u1, uint64_t u0, int64_t v)
 ssize_t tally_mean(const struct tally *tally)
 {
 	size_t count = tally_num(tally);
-	if (!count)
+	if (!count) {
 		return 0;
+	}
 
 	if (sizeof(tally->total[0]) == sizeof(uint32_t)) {
 		/* Use standard 64-bit arithmetic. */
@@ -365,10 +367,11 @@ static ssize_t bucket_range(const struct tally *tally, unsigned b, size_t *err)
 	ssize_t min, max;
 
 	min = bucket_min(tally->min, tally->step_bits, b);
-	if (b == tally->buckets - 1)
+	if (b == tally->buckets - 1) {
 		max = tally->max;
-	else
+	} else {
 		max = bucket_min(tally->min, tally->step_bits, b+1) - 1;
+	}
 
 	/* FIXME: Think harder about cumulative error; is this enough?. */
 	*err = (max - min + 1) / 2;
@@ -383,8 +386,9 @@ ssize_t tally_approx_median(const struct tally *tally, size_t *err)
 
 	for (i = 0; i < tally->buckets; i++) {
 		total += tally->counts[i];
-		if (total * 2 >= count)
+		if (total * 2 >= count) {
 			break;
+		}
 	}
 	return bucket_range(tally, i, err);
 }
@@ -418,9 +422,11 @@ static unsigned get_max_bucket(const struct tally *tally)
 {
 	unsigned int i;
 
-	for (i = tally->buckets; i > 0; i--)
-		if (tally->counts[i-1])
+	for (i = tally->buckets; i > 0; i--) {
+		if (tally->counts[i-1]) {
 			break;
+		}
+	}
 	return i;
 }
 
@@ -445,15 +451,17 @@ char *tally_histogram(const struct tally *tally,
 		/* We create a temporary then renormalize so < height. */
 		/* FIXME: Antialias properly! */
 		tmp = tally_new(tally->buckets);
-		if (!tmp)
+		if (!tmp) {
 			return NULL;
+		}
 		tmp->min = tally->min;
 		tmp->max = tally->max;
 		tmp->step_bits = tally->step_bits;
 		memcpy(tmp->counts, tally->counts,
 		       sizeof(tally->counts[0]) * tmp->buckets);
-		while ((max_bucket = get_max_bucket(tmp)) >= height)
+		while ((max_bucket = get_max_bucket(tmp)) >= height) {
 			renormalize(tmp, tmp->min, tmp->max * 2);
+		}
 		/* Restore max */
 		tmp->max = tally->max;
 		tally = tmp;
@@ -463,8 +471,9 @@ char *tally_histogram(const struct tally *tally,
 	/* Figure out longest line, for scale. */
 	largest_bucket = 0;
 	for (i = 0; i < tally->buckets; i++) {
-		if (tally->counts[i] > largest_bucket)
+		if (tally->counts[i] > largest_bucket) {
 			largest_bucket = tally->counts[i];
+		}
 	}
 
 	p = graph = (char *)malloc(height * (width + 1) + 1);
@@ -480,23 +489,26 @@ char *tally_histogram(const struct tally *tally,
 		row = height - i - 1;
 		count = (double)tally->counts[row] / largest_bucket * (width-1)+1;
 
-		if (row == 0)
+		if (row == 0) {
 			covered = snprintf(p, width, "%zi", tally->min);
-		else if (row == height - 1)
+		} else if (row == height - 1) {
 			covered = snprintf(p, width, "%zi", tally->max);
-		else if (row == bucket_of(tally->min, tally->step_bits, 0))
+		} else if (row == bucket_of(tally->min, tally->step_bits, 0)) {
 			*p = '+';
-		else
+		} else {
 			*p = '|';
+		}
 
-		if (covered > width)
+		if (covered > width) {
 			covered = width;
+		}
 		p += covered;
 
-		if (count > covered)
+		if (count > covered) {
 			count -= covered;
-		else
+		} else {
 			count = 0;
+		}
 
 		memset(p, '*', count);
 		p += count;