ccan: Correct some poor conventions in _info includes There are a couple of small problems with the includes used in most of ccan's _info files. * _info routinely uses printf(), and so should include <stdio.h>, but only some of them do. We get away with it, because they do include <string.h>, which apparently includes <stdio.h> indirectly, but we should be explicit about it. * Most _info files were including config.h after the system headers. That _seems_ sensible, but actually causes problems. Because config.h defines _GNU_SOURCE it can change the behaviour of the system headers. More specifically it can make them behave differently to how the individual module headers (which have included config.h) expects them to behave. This patch adjusts all the existing _info files and, more importantly, the template constructed by ccanlint. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
opt: relicense to GPLv2+ (from GPLv3+) Acked by contributors: Luke-Jr <luke@dashjr.org>: I don't have any objections Douglas Bagnall <douglas@halo.gen.nz>: Fine by me. Joel Stanley <joel@jms.id.au>: Fine with me. Brad Hards <bradh@frogmouth.net>: Ack. No response from Joey (trivial warning patch) or Andreas Schlick (one trivial patch, but he also wrote opt_free() (which was a 2 line function). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
opt: handle -Wcast-qual warnings.
opt: suggest they look at ccan/autodata. Nice for distributed option declaration.
various: make the _info License: wording uniform for GPL variants. GPL versions 2 and 3 both specifically mention "any later version" as the phrase which allows the user to choose to upgrade the license. Make sure we use that phrase, and make the format consistent across modules.
opt: Correct the separator in _info's example.
opt: Silence unsed param warning triggered by -Wextra The type checking function does not use its parameter: ccan/opt/opt.h: In function ‘_check_is_entry’: ccan/opt/opt.h:328:53: warning: unused parameter ‘e’ Annotate the function using UNUSED from compiler.h. This commit also adds compiler.h as a dependency for opt.
opt: correct description, and neaten main header order. Reordering header makes it more readable, and we don't rely on getopt_long any more.
licence->license: US English is the standard for code. If a Swedish-speaking Finn writes code in English, why should I complain about a few weird spellings?
opt: list ccan/typesafe_cb as a dependency.
opt: fix example to compile.
opt: fix examples so they compile.
opt: new module to parse commandline options.