]> git.ozlabs.org Git - bitfield/blobdiff - bitfield
Be a little more flexible with order strings
[bitfield] / bitfield
index ae9ab29eed906e4f7015bdd396e14b963aad4cc8..3b34aeb5b7514befdd0b9edc277cec373f9997fa 100644 (file)
--- a/bitfield
+++ b/bitfield
@@ -15,32 +15,33 @@ from getopt import getopt, GetoptError
 
 # List of paths to look for configuration files. If a directory is specified,
 # it will be (recursively) scanned for .conf files.
-configs = [os.path.join(os.getenv("HOME"), ".bitfields.conf"),
-               os.path.join(os.getenv("HOME"), ".bitfields.d")]
+configs = ["/etc/bitfield.d", "/etc/bitfield",
+               os.path.join(os.getenv("HOME"), ".bitfield.d"),
+               os.path.join(os.getenv("HOME"), ".bitfield.conf")]
 
 class bitfield:
-       def __init__(self, start_bit, end_bit, name):
-               self.start_bit = start_bit
-               self.end_bit = end_bit
+       def __init__(self, bits, name):
+               self.bits = bits
                self.name = name
                self.values = {}
 
-       def start_bit(self):
-               return self.start_bit
-
-       def end_bit(self):
-               return self.end_bit
-
        def width(self):
-               return 1 + self.end_bit - self.start_bit
+               return len(self.bits)
 
        def add_value(self, value, description):
                self.values[int(value)] = description
 
        def mask(self, reg_width, value):
-               shift = (reg_width - 1) - self.end_bit
-               return (((2 ** self.width() - 1) << (shift))
-                       & value) >> shift
+               ret = 0
+               out_len = len(self.bits)
+               for out_bit in range(0, out_len):
+                       in_bit = self.bits[out_bit]
+                       # shift this bit down to the LSB (and mask the rest)
+                       i = (value >> (reg_width - in_bit - 1)) & 1
+                       # shift back to the output position in the field
+                       i <<= out_len - out_bit - 1
+                       ret |= i
+               return ret
 
        def value(self, value):
                if value in self.values:
@@ -48,20 +49,23 @@ class bitfield:
                return None
 
        @staticmethod
-       def parse_bitfield(line):
+       def parse_bitfield(line, reg):
                a = line.split(None, 1)
                if len(a) != 2:
                        return None
                (range_str, name) = a
 
-               range = (None,None)
-               if range_str.find(':') != -1:
-                       r = range_str.split(":")
-                       range = (int(r[0]),int(r[1]))
-               else:
-                       range = (int(range_str),int(range_str))
-
-               return bitfield(range[0], range[1], name)
+               bits = []
+               for s in range_str.split(','):
+                       if ':' in s:
+                               (start, end) = s.split(':')
+                               start = reg.bit_number(int(start))
+                               end = reg.bit_number(int(end))
+                               bits.extend(range(start, end + 1, 1))
+                       else:
+                               bits.append(reg.bit_number(int(s)))
+               return bitfield(bits, name)
 
        @staticmethod
        def parse_value(line):
@@ -71,18 +75,26 @@ class bitfield:
                return a
 
 class register:
-       def __init__(self, name, width):
-               self.name = name
-               self.width = width
+       bit_0_is_msb = 0
+       bit_0_is_lsb = 1
+
+       def __init__(self, id):
+               self.id = id
                self.fields = []
+               # set defaults
+               self.name = None
+               self.bit_order = self.bit_0_is_msb
+               self.width = 64
 
-       def add_field(self, field,):
+       def add_field(self, field):
                self.fields.append(field)
 
        def decode(self, value, ignore_zero):
                field_width = (self.width + 3) / 4
                name_width = max(map(lambda f: len(f.name), self.fields))
+
                str = "0x%0*lx [%d]\n" % (field_width, value, value)
+
                for field in self.fields:
                        v = field.mask(self.width, value);
                        if ignore_zero and v == 0:
@@ -95,6 +107,11 @@ class register:
                                str += "%*s: 0x%x\n" \
                                        % (name_width, field.name, v)
                return str
+       
+       def bit_number(self, number):
+               if self.bit_order == self.bit_0_is_lsb:
+                       number = self.width - 1 - number
+               return number
 
 def list_regs(regs):
        for (id, r) in regs.iteritems():
@@ -114,6 +131,11 @@ def parse_config(bnf, regs, file):
 
        tokens = bnf.parseString(f.read())
 
+       order_map = {'bit-0-is-lsb':    register.bit_0_is_lsb,
+                       'bit-0-is-msb': register.bit_0_is_msb,
+                       'ibm':          register.bit_0_is_msb,
+                       'default':      register.bit_0_is_msb}
+
        for tok in tokens:
                ts = tok.asList()
                id = ts.pop(0)
@@ -122,19 +144,19 @@ def parse_config(bnf, regs, file):
                        raise ConfigurationError(file,
                                "Register %s is already defined" % id)
 
-               # default to 64 bit registers
-               width = 64
-               name = None
+               reg = register(id)
+
+               alias_id = None
                fields = []
 
                for t in ts:
                        if t[0] == 'name':
                                name = t[1]
-                               name = name.strip()
+                               reg.name = name.strip()
                        elif t[0] == 'width':
-                               width = int(t[1])
+                               reg.width = int(t[1])
                        elif t[0] == 'field':
-                               f = bitfield.parse_bitfield(t[1])
+                               f = bitfield.parse_bitfield(t[1], reg)
                                if f is None:
                                        raise ConfigurationError(file,
                                                "Invalid field in %s" % id)
@@ -149,8 +171,39 @@ def parse_config(bnf, regs, file):
                                                "Invalid value in %s" % id)
 
                                fields[-1].add_value(v[0], v[1])
+                       elif t[0] == 'order':
+                               if len(fields) != 0:
+                                       raise ConfigurationError(file,
+                                               ("bit order defined after " \
+                                               + "fields in %s") % id)
 
-               if name is None or name == '':
+                               order_str = t[1].strip().lower()
+                               order_str = order_str.replace(' ', '-')
+
+                               if order_str not in order_map.keys():
+                                       raise ConfigurationError(file,
+                                               "Invalid bit order %s in %s" % \
+                                               (order_str, id))
+                               reg.bit_order = order_map[order_str]
+                               
+                       elif t[0] == 'alias':
+                               alias_id = t[1].strip()
+
+               if alias_id is not None:
+                       if reg.name is not None or fields != []:
+                               raise ConfigurationError(file, ("Definiton " \
+                                       + "for %s is an alias, but has other " \
+                                       + "attributes") % id)
+
+                       if not regs.has_key(alias_id):
+                               raise ConfigurationError(file, "Aliasing "
+                                       "non-existent register %s (from %s)" \
+                                       % (alias_id, id))
+
+                       reg = regs[alias_id]
+                       continue
+
+               if reg.name is None or reg.name == '':
                        raise ConfigurationError(file,
                                "No name for entry %s" % id)
 
@@ -158,11 +211,10 @@ def parse_config(bnf, regs, file):
                        raise ConfigurationError(file,
                                "Register %s has no fields" % id)
 
-               r = register(name, width)
                for f in fields:
-                       r.add_field(f)
+                       reg.add_field(f)
 
-               regs[id] = r
+               regs[id] = reg
 
 def parse_config_dir(data, dir, fnames):
        (bnf, regs) = data
@@ -210,6 +262,21 @@ def parse_all_configs(configs):
 def usage(prog):
        print "Usage: %s <-l> | <-s pattern> | [-n] register [value...]" % prog
 
+def decode_value(reg, value, options):
+       try:
+               i = long(value, 0)
+       except ValueError, e:
+               print "error: invalid value '%s'" % value
+               return
+
+       if i > ((1 << reg.width) - 1):
+               print ("error: value '%s' is too large " + \
+                       "for %d-bit register '%s'") % (value, reg.width, reg.id)
+               return
+
+       print reg.decode(i, options['non-zero'])
+
+
 def main():
        try:
                (opts, args) = getopt(sys.argv[1:], "hlns:", \
@@ -257,20 +324,19 @@ def main():
                print "No such register '%s'" % reg_id
                return 1
 
-       r = regs[reg_id]
-       print "decoding as %s" % r.name
+       reg = regs[reg_id]
+       print "decoding as %s" % reg.name
 
        if args:
-               values = args
+               value_iter = args.__iter__()
        else:
-               try:
-                       values = sys.stdin.readlines()
-               except KeyboardInterrupt, e:
-                       return
-
-       for value in values:
-               i = long(value.strip(), 0)
-               print r.decode(i, options['non-zero'])
+               value_iter = iter(sys.stdin.readline, '')
+               
+       try:
+               for value in value_iter:
+                       decode_value(reg, value.strip(), options)
+       except KeyboardInterrupt, e:
+               pass
 
        return 0