From 9793fd2e7762623ef4bbaaa1a16dbedd10659599 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
Date: Wed, 30 Dec 2020 11:04:36 +0100
Subject: [PATCH] Fix indicating failure in Linux get_if_hwaddr() function
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

This function should return negative value on error.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 pppd/sys-linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pppd/sys-linux.c b/pppd/sys-linux.c
index 6e14238..fd758da 100644
--- a/pppd/sys-linux.c
+++ b/pppd/sys-linux.c
@@ -2087,7 +2087,7 @@ get_if_hwaddr(u_char *addr, char *name)
 
 	sock_fd = socket(AF_INET, SOCK_DGRAM, 0);
 	if (sock_fd < 0)
-		return 0;
+		return -1;
 	memset(&ifreq.ifr_hwaddr, 0, sizeof(struct sockaddr));
 	strlcpy(ifreq.ifr_name, name, sizeof(ifreq.ifr_name));
 	ret = ioctl(sock_fd, SIOCGIFHWADDR, &ifreq);
-- 
2.39.2