From 6c69b9ba6b46ea0d15f90eb1649cbb2acf6a28de Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Mon, 30 Aug 2010 22:40:04 +0930 Subject: [PATCH] ccanlint: fix valgrind test. We were not actually recording valgrind failures in ccanlint! --- tools/ccanlint/tests/run_tests_valgrind.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/ccanlint/tests/run_tests_valgrind.c b/tools/ccanlint/tests/run_tests_valgrind.c index 233a719..9dd8247 100644 --- a/tools/ccanlint/tests/run_tests_valgrind.c +++ b/tools/ccanlint/tests/run_tests_valgrind.c @@ -18,7 +18,7 @@ static const char *can_run_vg(struct manifest *m) { unsigned int timeleft = default_timeout_ms; - char *output = run_command(m, &timeleft, "valgrind -q true"); + char *output = run_command(m, &timeleft, "valgrind -q --error-exitcode=0 true"); if (output) return talloc_asprintf(m, "No valgrind support: %s", output); @@ -54,7 +54,8 @@ static void *do_run_tests_vg(struct manifest *m, list_for_each(&m->run_tests, i, list) { run_tests_vg.total_score++; cmdout = run_command(m, timeleft, - "valgrind -q %s", i->compiled); + "valgrind -q --error-exitcode=100 %s", + i->compiled); if (cmdout) { res = talloc(list, struct run_tests_result); res->file = i; @@ -66,7 +67,8 @@ static void *do_run_tests_vg(struct manifest *m, list_for_each(&m->api_tests, i, list) { run_tests_vg.total_score++; cmdout = run_command(m, timeleft, - "valgrind -q %s", i->compiled); + "valgrind -q --error-exitcode=100 %s", + i->compiled); if (cmdout) { res = talloc(list, struct run_tests_result); res->file = i; -- 2.39.2