From 5c1767485d0879cdacdfeed218f5e91cc2e9f716 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Mon, 3 Apr 2017 01:15:53 +1000 Subject: [PATCH] net: Add check for failure of setsockopt() make_listen_fd() didn't check for failure of setsockopt(). There's no real reason not to, since we have an obvious way to report an error to the caller. Found with Coverity Scan. Signed-off-by: David Gibson --- ccan/net/net.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ccan/net/net.c b/ccan/net/net.c index e9199839..11c6b670 100644 --- a/ccan/net/net.c +++ b/ccan/net/net.c @@ -238,7 +238,9 @@ static int make_listen_fd(const struct addrinfo *addrinfo) if (fd < 0) return -1; - setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); + if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) != 0) + goto fail; + if (bind(fd, addrinfo->ai_addr, addrinfo->ai_addrlen) != 0) goto fail; -- 2.39.2