]>
git.ozlabs.org Git - ccan-lca-2011.git/log
Rusty Russell [Fri, 21 Jan 2011 03:50:45 +0000 (14:20 +1030)]
lca2011: dump talloc tree in child.
Avoids stopping the entire server just for debug dumps.
Rusty Russell [Fri, 21 Jan 2011 03:50:02 +0000 (14:20 +1030)]
lca2011: dump talloc tree on SIGUSR1
Useful for finding runtime memory leaks.
Rusty Russell [Tue, 25 Jan 2011 00:29:15 +0000 (10:59 +1030)]
lca2011: fix client disconnect during answer (poorly).
We seek an oracle or a client when we need one, and unset when we
are destroyed. This can cause crossed answers; better would be to
actually move the questions/answers around.
Rusty Russell [Fri, 21 Jan 2011 03:47:57 +0000 (14:17 +1030)]
lca2011: test client disconnect.
Rusty Russell [Fri, 21 Jan 2011 05:29:34 +0000 (15:59 +1030)]
lca2011: turn it into a true Usenet Oracle.
We switch the port, since we keep the previous parrot version running.
This version crashes on client disconnect.
Rusty Russell [Fri, 21 Jan 2011 05:29:42 +0000 (15:59 +1030)]
lca2011: make our server parrot the last answer it got.
Include my own fairly lame attempt to match up with the woodchuck question.
Rusty Russell [Tue, 25 Jan 2011 00:28:10 +0000 (10:58 +1030)]
lca2011: add greeting and prefix states.
Rusty Russell [Fri, 21 Jan 2011 04:42:21 +0000 (15:12 +1030)]
lca2011: valgrind catches an error for us.
When we moved the clients[] array into oserver, we didn't initialize it.
Before, it was a static, so implicitly set to NULL.
Rusty Russell [Sat, 22 Jan 2011 03:40:51 +0000 (14:10 +1030)]
lca2011: don't use void * for the handle.
And don't keep global state: it's messy, and you can never invoke two of them.
Rusty Russell [Sat, 22 Jan 2011 03:40:51 +0000 (14:10 +1030)]
lca2011: rewrite to a serious server
This uses tevent and callback, and a simple state machine.
Rusty Russell [Fri, 21 Jan 2011 03:41:51 +0000 (14:11 +1030)]
lca2011: add option parsing using ccan/opt.
Rusty Russell [Fri, 21 Jan 2011 03:41:35 +0000 (14:11 +1030)]
lca2011: use failtest
This gives us one more line of coverate for very little cost.
Rusty Russell [Fri, 21 Jan 2011 03:41:16 +0000 (14:11 +1030)]
lca2011: simpler testing by not having oserver_setup exit.
Note the use of close_noerr here to preserve the errno.
Rusty Russell [Fri, 21 Jan 2011 03:40:45 +0000 (14:10 +1030)]
lca2011: simpler testing by not having oserver_serve exit.
This makes it easier to test error paths, too.
Rusty Russell [Fri, 21 Jan 2011 03:38:50 +0000 (14:08 +1030)]
lca2011: enhance test/run to use ccan/foreach
Rusty Russell [Fri, 21 Jan 2011 03:38:35 +0000 (14:08 +1030)]
lca2011: enhance test/run to try multiple inputs.
Rusty Russell [Fri, 21 Jan 2011 03:40:03 +0000 (14:10 +1030)]
lca2011: header documentation.
Particularly, the example sections (compile-tested thanks to ccanlint).
Rusty Russell [Fri, 21 Jan 2011 03:37:27 +0000 (14:07 +1030)]
lca2011: test
Rusty Russell [Sun, 23 Jan 2011 12:03:46 +0000 (22:33 +1030)]
lca2011: oserver _info file.
Header from folded patch 'ccanlint-idempotent-and-license.patch':
lca2011: oserver idempotent and license link and tag.
Header from folded patch 'ccanlint-fix-control-reaches-end.patch':
lca2011: mark oserver_serve NORETURN.
Rusty Russell [Sun, 23 Jan 2011 12:04:10 +0000 (22:34 +1030)]
lca2011: The initial server.
Actually written as a CCAN module (ie. library).
Rusty Russell [Fri, 21 Jan 2011 03:36:26 +0000 (14:06 +1030)]
cdump: features which weren't in genparser
1) size_t bundling an unbundling.
2) CDUMP_IGNORE to avoid saving struct members.
3) const handling (ie. ignore the keyword).
Rusty Russell [Fri, 21 Jan 2011 03:35:08 +0000 (14:05 +1030)]
cdump: first cut of translation of Tridge's genstruct junkcode.
Mainly, all new bugs.
Rusty Russell [Sat, 22 Jan 2011 03:39:59 +0000 (14:09 +1030)]
lca2011: hacky import of tevent.
Rusty Russell [Wed, 26 Jan 2011 23:42:50 +0000 (10:12 +1030)]
lca2011: links and preparation
Brad Hards [Wed, 19 Jan 2011 06:03:32 +0000 (17:03 +1100)]
ccanlint: protect against the function element in the doc section being null
This can happen if the documentation doesn't have a properly formatted summary line,
and it causes the examples_relevant test to segfault.
Rusty Russell [Sat, 22 Jan 2011 02:02:54 +0000 (12:32 +1030)]
ccanlint: always print \n at end of error message.
Brad Hards fixed a two places where score->error was not \n-terminated,
and then I found a few more, so make it automatic.
Rusty Russell [Thu, 20 Jan 2011 01:01:11 +0000 (11:31 +1030)]
ccanlint: don't collect results from test children
This confuses the output, and makes us sometimes see spurious
failure. At least we will still catch valgrind errors in
children of failtest, thanks to --error-exitcode=101.
Rusty Russell [Tue, 18 Jan 2011 07:21:51 +0000 (17:51 +1030)]
opt: correct description, and neaten main header order.
Reordering header makes it more readable, and we don't rely on
getopt_long any more.
Rusty Russell [Tue, 18 Jan 2011 01:47:17 +0000 (12:17 +1030)]
ccanlint: fix _info option handling
Two places were using a bogus ccanlint struct: the side-effect was
that valgrind options didn't work, nor did license fixups.
Make REGISTER_TEST do the extern declaration, and remove the bogus
ones.
Rusty Russell [Tue, 18 Jan 2011 00:44:46 +0000 (11:14 +1030)]
strsplit: remove nump argument
You can use talloc_array_length() to get the length of a tallocated array.
Rusty Russell [Tue, 18 Jan 2011 00:36:23 +0000 (11:06 +1030)]
talloc: talloc_array_length()
I originally called this talloc_length(), but SAMBA upstream uses
talloc_array_length.
Rusty Russell [Sun, 9 Jan 2011 02:50:14 +0000 (13:20 +1030)]
ccanlint: -k all
Use this to preserve the entire working directory.
Rusty Russell [Sun, 9 Jan 2011 02:49:15 +0000 (13:19 +1030)]
ccanlint: -k should not pollute module directory.
It leads to numerous problems, such as the next ccanlint getting confused
trying to compile examples, and "-k examples_compile -k examples_exist"
giving bogus errors.
So instead we leave the temporary dir lying around and delete
individual files which aren't marked "keep".
Rusty Russell [Tue, 18 Jan 2011 00:35:37 +0000 (11:05 +1030)]
failtest: free up everything on exit.
Otherwise valgrind will report that tests leak memory.
Rusty Russell [Tue, 18 Jan 2011 00:38:34 +0000 (11:08 +1030)]
failtest: failtest_restore.h as an antidote to function overload.
This makes some cases simpler, where you no longer want malloc etc.
to fail.
Brad Hards [Sun, 16 Jan 2011 06:50:51 +0000 (17:50 +1100)]
wwviaudio: spelling fix
Brad Hards [Sun, 16 Jan 2011 06:50:24 +0000 (17:50 +1100)]
tdb2: spelling fix
Brad Hards [Sun, 16 Jan 2011 06:50:03 +0000 (17:50 +1100)]
tdb: spelling fixes
Brad Hards [Sun, 16 Jan 2011 06:49:20 +0000 (17:49 +1100)]
tap: spelling fix
Brad Hards [Sun, 16 Jan 2011 06:48:53 +0000 (17:48 +1100)]
talloc: spelling fix.
Brad Hards [Sun, 16 Jan 2011 06:48:20 +0000 (17:48 +1100)]
rbtree: spelling fixes
Brad Hards [Sun, 16 Jan 2011 06:22:39 +0000 (17:22 +1100)]
opt: spelling fixes.
Brad Hards [Sun, 16 Jan 2011 06:22:14 +0000 (17:22 +1100)]
nfs: spelling fixes.
Brad Hards [Sun, 16 Jan 2011 06:21:39 +0000 (17:21 +1100)]
list: spelling fixes
Brad Hards [Sun, 16 Jan 2011 06:21:12 +0000 (17:21 +1100)]
iscsi: spelling fixes.
Brad Hards [Sun, 16 Jan 2011 06:19:51 +0000 (17:19 +1100)]
hash: spelling fix
Brad Hards [Sun, 16 Jan 2011 06:19:12 +0000 (17:19 +1100)]
btree: spelling fix
Brad Hards [Sun, 16 Jan 2011 06:17:36 +0000 (17:17 +1100)]
ciniparser: spelling fixes
Brad Hards [Sun, 16 Jan 2011 06:16:46 +0000 (17:16 +1100)]
junkcode: spelling fixes.
Brad Hards [Sun, 16 Jan 2011 06:15:32 +0000 (17:15 +1100)]
array: spelling fixes.
Brad Hards [Sun, 16 Jan 2011 05:22:46 +0000 (16:22 +1100)]
str: change example to match function being explained.
Looks like the example was copy-n-pasted from the previous entry.
Rusty Russell [Mon, 17 Jan 2011 05:50:15 +0000 (16:20 +1030)]
ccanlint: check examples actually mention thing they are demonstrating.
Brad suggested this after finding one such cut & paste in str:
rusty@vivaldi:~/devel/cvs/ccan/ccan/str$ ../../tools/ccanlint/ccanlint
Example: sections demonstrate appropriate function (examples_relevant): FAIL
/home/rusty/devel/cvs/ccan/ccan/str/str.h:64:Example for strcount doesn't mention it
Total score: 37/38
Rusty Russell [Mon, 17 Jan 2011 05:49:13 +0000 (16:19 +1030)]
ccanlint: fix trailing / in -d.
Before:
$ tools/ccanlint/ccanlint -d ccan/talloc/
Module's source code has no trailing whitespace (no_trailing_whitespace): FAIL
: Total score: 0/1
After:
$ tools/ccanlint/ccanlint -d ccan/talloc/
Module's source code has no trailing whitespace (no_trailing_whitespace): FAIL
talloc: Total score: 0/1
Rusty Russell [Mon, 17 Jan 2011 05:47:49 +0000 (16:17 +1030)]
ccanlint: score_file_error() takes printf-format
We simply build up the error string in score_file_error; a bit different
but simpler than current behaviour. We keep around struct file_error
because some tests need it.
Rusty Russell [Mon, 17 Jan 2011 05:34:42 +0000 (16:04 +1030)]
ccanlint: fix score for info_summary_single_line
My refactoring introduced a bug: we need to set score=1 for the success case.
Brad Hards [Mon, 17 Jan 2011 03:02:36 +0000 (13:32 +1030)]
ciniparser: Separate summary line and description text for metadata
Brad Hards [Mon, 17 Jan 2011 03:02:36 +0000 (13:32 +1030)]
block_pool: Change metadata layout so initial description is all on one line.
With the original layout, we got:
Summary:
An efficient allocator for blocks that don't need to be
....
Description:
resized or freed.
Rusty Russell [Mon, 17 Jan 2011 03:52:29 +0000 (14:22 +1030)]
ccanlint: neaten info_summary_single_line with new doc_section info.
Rusty Russell [Mon, 17 Jan 2011 03:44:43 +0000 (14:14 +1030)]
ccanlint: keep mapping back to original source line for doc_extract
Makes reporting of documentation easier.
Brad Hards [Mon, 17 Jan 2011 03:02:36 +0000 (13:32 +1030)]
ccanlint: add test case for metadata summary line on a single separate line.
Rusty Russell [Thu, 13 Jan 2011 08:55:01 +0000 (19:25 +1030)]
htable: fix type of cmpfn in htable_type
It in fact takes an object and a key to compare, not two keys.
The test case had the key as first element of the object, so it worked,
but ccanlint lost track of module dependencies due to this bug, and thus
would build submodules multiple times.
Rusty Russell [Mon, 10 Jan 2011 05:55:22 +0000 (16:25 +1030)]
rbtree: fix allocation failre paths.
Rusty Russell [Mon, 10 Jan 2011 05:17:24 +0000 (15:47 +1030)]
rbtree: don't use temporary context to destroy rbtree
It leads to a memory leak if the allocation fails (as we reparent onto NULL).
Also, the extra allocation in the failure path increases test time for
failtest (under valgrind) by a factor of 2.
Rusty Russell [Mon, 10 Jan 2011 05:53:46 +0000 (16:23 +1030)]
rbtree: use failtest to check handling of allocation failures.
Unfortunately this means we have to reduce run-many from 1000 nodes to 100
(as forking under valgrind is really slow: test takes about 2 minutes with
100 nodes).
Rusty Russell [Mon, 10 Jan 2011 05:51:24 +0000 (16:21 +1030)]
rbtree: fix memory leak in tests
The data is not made a child of the tree: the nodes are made children of the
data. So we must explicitly free the data objects.
Rusty Russell [Mon, 10 Jan 2011 05:55:48 +0000 (16:25 +1030)]
rbtree: vary insert and delete orders in test
This covers more code than simply doing an ordered delete/insert.
Rusty Russell [Mon, 10 Jan 2011 03:36:40 +0000 (14:06 +1030)]
talloc: allow replacement allocator
This allows us to both allocators which handle failure themselves, and
allocators which insert failures.
Rusty Russell [Mon, 10 Jan 2011 05:32:03 +0000 (16:02 +1030)]
talloc: fixed a use after free error
(Import from SAMBA commit
6f51a1f45bf4de062cce7a562477e8140630a53d ):
this is the minimal fix for the problem Rusty found. I previously
thought that the best fix would be to change tc->parent to be valid
for all pointers, but that is expensive for realloc with large numbers
of child pointers, which is much more commmon than I expected it to
be.
Rusty Russell [Mon, 10 Jan 2011 03:31:47 +0000 (14:01 +1030)]
talloc: use failtest to test failure paths.
Rusty Russell [Mon, 10 Jan 2011 04:12:38 +0000 (14:42 +1030)]
failtest: new module.
A module designed to help test "never fails" functions like malloc.
Rusty Russell [Mon, 10 Jan 2011 05:30:48 +0000 (16:00 +1030)]
tap: add fail callback
This is useful for failtest, so we can abort on first failure.
Rusty Russell [Sun, 9 Jan 2011 01:26:41 +0000 (11:56 +1030)]
ccanlint: fix and simplify depends-accurate (with strreg)
Rusty Russell [Sat, 8 Jan 2011 09:39:25 +0000 (20:09 +1030)]
ccanlint: fix total score for running examples
Don't count examples which didn't compile (expected, as we mangle them in
various different ways).
Rusty Russell [Sat, 8 Jan 2011 10:13:59 +0000 (20:43 +1030)]
ccanlint: fix uninitialized variable
Rusty Russell [Sat, 8 Jan 2011 08:07:19 +0000 (18:37 +1030)]
ccanlint: use strreg for section extraction.
Makes it simpler and clearer.
Rusty Russell [Sat, 8 Jan 2011 08:06:56 +0000 (18:36 +1030)]
Makefile: append git revision to "make scores"
Good for testing ccanlint changes.
Rusty Russell [Sat, 8 Jan 2011 02:45:35 +0000 (13:15 +1030)]
str_talloc: strreg
Useful wrapper for extended POSIX regular expressions.
Rusty Russell [Fri, 7 Jan 2011 23:47:37 +0000 (10:17 +1030)]
str: strcount
Useful routine to count number of matches in a string.
Rusty Russell [Thu, 6 Jan 2011 03:50:26 +0000 (14:20 +1030)]
str: clean up tests so ccanlint doesn't complain about memory leaking.
Rusty Russell [Fri, 7 Jan 2011 11:51:29 +0000 (22:21 +1030)]
ccanlint: use positive description for test_pass_valgrind_noleaks
A bit more awkward, but more consistent with everything else.
Rusty Russell [Fri, 7 Jan 2011 11:50:44 +0000 (22:20 +1030)]
ccanlint: print keys in output
Since test keys are used for --target=, this is useful.
Rusty Russell [Fri, 7 Jan 2011 11:50:13 +0000 (22:20 +1030)]
ccanlint: rename files to match keys
Rusty Russell [Fri, 7 Jan 2011 11:50:04 +0000 (22:20 +1030)]
ccanlint: rename structures to match keys
Rusty Russell [Fri, 7 Jan 2011 11:49:49 +0000 (22:19 +1030)]
ccanlint: list dependencies by key
Joey Adams also pointed out that we should use strings for the dependency
lists. Moving them into the structure also somewhat simplifies it.
Rusty Russell [Fri, 7 Jan 2011 11:48:41 +0000 (22:18 +1030)]
ccanlint: rename test keys
Joey Adams rightly points out that the current keys are a mess: ideally the
filenames, test keys and structure names in ccanlint should be the same.
First step is to make the test names all regular, of basic form <noun>_<verb>
(eg "tests_exist" rather than "has-tests").
Rusty Russell [Fri, 7 Jan 2011 02:52:43 +0000 (13:22 +1030)]
Add scores/ directory to .gitignore.
Joey Adams [Thu, 6 Jan 2011 20:35:51 +0000 (15:35 -0500)]
ccanlint: added --test-dep-graph option
This option prints the dependency graph of ccanlint's tests
in Graphviz .dot format.
Sample usage:
ccanlint --test-dep-graph | dot -Tpng > out.png && eog out.png
Joey Adams [Thu, 6 Jan 2011 20:12:18 +0000 (15:12 -0500)]
ccanlint: fix segfault caused by tests not depending on the "info" test.
These tests:
"depends-exist" (compulsory_tests/check_depends_exist.c)
"info-documentation" (tests/has_info_documentation.c)
used m->info_file without checking if it was NULL,
leading to a segfault when no _info file was present.
Some other tests also used m->info_file without depending on "info",
but are taken care of indirectly by this patch.
Joey Adams [Thu, 6 Jan 2011 15:50:04 +0000 (10:50 -0500)]
opt: Fix warnings with gcc-4.5 (same approach as commit
6535bde )
&*ptr is used in some other macros, but at a glance, they look like
cases where the pointer shouldn't be NULL . Didn't change those,
and if we get more warnings, we'll cross that bridge when we get to it.
For now, I suppose they are just free NULL checks.
Rusty Russell [Thu, 6 Jan 2011 01:54:05 +0000 (12:24 +1030)]
daemonize: set stderr to /dev/null.
Rusty Russell [Thu, 6 Jan 2011 01:45:03 +0000 (12:15 +1030)]
daemonize: make valgrind happy.
Rusty Russell [Thu, 6 Jan 2011 01:37:37 +0000 (12:07 +1030)]
daemonize: use BSD-MIT as License: string in _info
The parenthesized thing is confusing and ccanlint dislikes it.
Rusty Russell [Thu, 6 Jan 2011 01:37:05 +0000 (12:07 +1030)]
ccanlint: allow BSD-MIT for MIT license.
There are a large number of BSD variants out there, be explicit.
Rusty Russell [Thu, 6 Jan 2011 00:56:47 +0000 (11:26 +1030)]
ccanlint: fix parsing bug which believes lines starting with - are a section header.
Rusty Russell [Tue, 4 Jan 2011 10:41:47 +0000 (21:11 +1030)]
ccanlint: have valgrind fail with an error, always
The upcoming failtest module can only tell that a child failed when it
exits with a non-zero error. So we need this, although it means for ccanlint
it still needs to look at output to distinguish a memory leak from a real
error.
Rusty Russell [Tue, 4 Jan 2011 10:41:47 +0000 (21:11 +1030)]
ccanlint: compile modules required by examples.
If an example #includes <ccan/foo/...> we assume it needs module foo,
but we would fail instead of building it if it isn't built.
Rusty Russell [Tue, 4 Jan 2011 10:41:47 +0000 (21:11 +1030)]
ccanlint: make get_manifest cache manifests
As we start doing more building of dependencies, this saves us effort.
Rusty Russell [Tue, 4 Jan 2011 10:42:41 +0000 (21:12 +1030)]
compiler: NORETURN
Rusty Russell [Sat, 1 Jan 2011 06:44:05 +0000 (17:14 +1030)]
tlist: typesafe variant of list module.
I chose not to do the "macro creates set of routines" approach, as
we can be almost as safe with a struct containing a pointer to the member
type.
Rusty Russell [Sat, 1 Jan 2011 06:43:04 +0000 (17:13 +1030)]
list: LIST_HEAD_INIT
I find hiding the declaration in LIST_HEAD() a bit weird.