]>
git.ozlabs.org Git - patchwork/log
Jeremy Kerr [Fri, 18 Sep 2009 02:24:42 +0000 (10:24 +0800)]
Add pwclient items to TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Thomas Gleixner [Thu, 17 Sep 2009 11:23:09 +0000 (13:23 +0200)]
Add Message-Id to xmlrpc patch_get_mbox headers
While trying to utilize patchwork for my daily workflow I noticed that
the xmlrpc patch_get_mbox function does not add the original message
id to the headers. That forces me to look it up with the browser which
is a major PITA.
Add Message-Id to the headers.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Mauro Carvalho Chehab [Tue, 17 Feb 2009 10:34:51 +0000 (07:34 -0300)]
pwclient fix for handling messages with UTF-8
pwclient works fine viewing utf-8 messages, if you don't try to redirect stdout.
However, if you do things like pwclient view 5063 >/tmp/patch, it fails
due to the weird character handling logic in python:
Traceback (most recent call last):
File "/usr/local/bin/pwclient", line 446, in ?
main()
File "/usr/local/bin/pwclient", line 411, in main
print s
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 249: ordinal not in range(128)
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Abhishek Kulkarni [Fri, 14 Aug 2009 18:03:56 +0000 (12:03 -0600)]
xmlrpc: Remove duplicated "name" field
Remove duplicated "name" field from the list of allowed
fields for a patch list filter in the XML RPC interface.
Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Eduardo Habkost [Thu, 13 Aug 2009 21:09:17 +0000 (18:09 -0300)]
tests: check some edge cases in bundle reordering tests
While testing BundleReorderTest, I felt like adding more test cases to
check if reordering is touching only the right patches on the bundle.
This increases the number of patches on the test bundle to 5, and
changes the code to do the following tests:
- Reorder all patches
- Reorder only the first 3 patches
- Reorder only the last 3 patches
- Reorder only the middle 3 patches
- On all above tests, check if the 'order' field on the BundlePatch
objects is still consistent
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Eduardo Habkost [Thu, 13 Aug 2009 20:21:23 +0000 (17:21 -0300)]
tests: Fix 'order_start' on BundleReorderTest unit test
The 'order_start' parameter on the reorder form should be a patch ID,
not the 'order' field of BundlePatch.
This fixes the following test failure:
> ======================================================================
> FAIL: testBundleReorder (patchwork.tests.bundles.BundleReorderTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/mnt/common/code/admin/rh-patchwork/apps/patchwork/tests/bundles.py", line 358, in testBundleReorder
> self.failUnlessEqual(response.status_code, 200)
> AssertionError: 404 != 200
>
> ----------------------------------------------------------------------
> Ran 123 tests in 4.527s
>
> FAILED (failures=1)
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 1 Aug 2009 06:05:37 +0000 (16:05 +1000)]
parser: allow short-form List-Id headers
Some lists (eg, nongnu.org) have short-form List-Id headers. For
example:
List-Id: qemu-devel.nongnu.org
Although RFC 2919 prescribes that:
list-id-header = "List-ID:" [phrase] "<" list-id ">" CRLF
we should allow for these headers anyway.
Based on an original patch from "J.H." <warthog9@kernel.org>.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 11 Jul 2009 02:03:55 +0000 (12:03 +1000)]
docs: add note about -pass-header Authorization' to INSTALL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Carl-Daniel Hailfinger [Wed, 8 Jul 2009 02:49:32 +0000 (12:49 +1000)]
Fix unarchive action
We want to un-archive, not re-archive.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 8 Jul 2009 02:39:37 +0000 (12:39 +1000)]
Add nacked-by tag
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Jun 2009 05:49:32 +0000 (15:49 +1000)]
views: order bundle correctly
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Apr 2009 06:16:42 +0000 (17:16 +1100)]
templates: close table cell in project maintainer list
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Apr 2009 06:23:45 +0000 (17:23 +1100)]
views: separate project views into separate file
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 06:31:02 +0000 (17:31 +1100)]
docs: remove completed todo items
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 06:28:19 +0000 (17:28 +1100)]
docs: add items to todo
Additions to pwclient.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 02:43:08 +0000 (13:43 +1100)]
tests: test creating bundles with existing names
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 02:41:26 +0000 (13:41 +1100)]
migration: fix whitespace
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 02:40:49 +0000 (13:40 +1100)]
migration: reset bundlepatch sequence on setup
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Mauro Carvalho Chehab [Tue, 30 Dec 2008 22:46:16 +0000 (20:46 -0200)]
Add extra patch meta tags (Tested/Reviewed/Nacked-by)
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Mauro Carvalho Chehab [Wed, 19 Nov 2008 01:00:32 +0000 (23:00 -0200)]
Fix non-ascii character encodings on xmlrpc interface
The current xmlrpc interface dies when trying to retrieve patches
that contain non-ascii characters.
This change uses unicode() rather than str().
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 13 Feb 2009 02:52:19 +0000 (13:52 +1100)]
[views] Check count() for duplicate bundle patches, rather than try/except
If the exception is raised, the transaction will still be in a bad
state, due to the foreign key constraint.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 13 Feb 2009 01:02:48 +0000 (12:02 +1100)]
[views] Don't create bundles with no name
Check to see that we have a valid name before creating.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 12 Feb 2009 11:17:55 +0000 (22:17 +1100)]
[docs] Remove done things from TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 12 Feb 2009 11:11:48 +0000 (22:11 +1100)]
[mbox] Add extra newline after patch comment
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 12 Feb 2009 11:01:09 +0000 (22:01 +1100)]
[mbox] Put ACKs before '---' updates
Update the Patch's mbox() function to split into '--- update'
sections, allowing us to add Acks and Signoffs in the right place
Add tests too.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Feb 2009 03:30:38 +0000 (14:30 +1100)]
[sql] Fix up bundle-reorder migration script
We need to add grants for the new table, and drop the old to
prevent reference constraint errors.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Feb 2009 00:47:40 +0000 (11:47 +1100)]
[tests] Add initial bundle tests
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sun, 8 Feb 2009 10:40:17 +0000 (21:40 +1100)]
Bundle reordering support
Bundles can now be reordered and saved.
Add dependency on jquery in INSTALL.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sun, 8 Feb 2009 03:00:11 +0000 (14:00 +1100)]
[views] Allow Order class to be user-editable
This can be enabled with the editable_order parameter to
generic_list
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sun, 8 Feb 2009 02:28:22 +0000 (13:28 +1100)]
[sql] Perserve bundle ordering in bundle reorder migration script
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 7 Feb 2009 04:48:37 +0000 (15:48 +1100)]
Normalise order numbers in bundle-ordering migration SQL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 7 Feb 2009 04:44:07 +0000 (15:44 +1100)]
Complete bundle ordering migration script
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 29 Jan 2009 06:38:46 +0000 (17:38 +1100)]
Initial bundle reordering support
todo:
* implement ajax reorder api
* finish migration script
* order patches in bundle view
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 27 Jan 2009 22:31:35 +0000 (09:31 +1100)]
Add per-user default filters to TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 27 Jan 2009 02:26:49 +0000 (13:26 +1100)]
[models] use case-insensitve lookup when creating confirmation
We were getting multiple entries when the case-sensitive lookup
failed.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 8 Jan 2009 07:23:26 +0000 (16:23 +0900)]
Add TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 18 Dec 2008 23:50:16 +0000 (08:50 +0900)]
Use 'from' import for urlresolvers
Some python installs can't seem to find the fully-qualified module,
so use the 'from'-style import instead.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 29 Oct 2008 00:21:05 +0000 (11:21 +1100)]
[models] Make patches unique on (msgid, project), not just (msgid)
On patchwork.ozlabs.org, we may see multiple patches for different
projects, but with the same message-id.
We want these patches to show up on both projects, so we need to change
the current UNIQUE contstraint on msgid.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 23 Oct 2008 03:56:18 +0000 (14:56 +1100)]
[views] Use standard UserAdmin for admin site
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Mon, 20 Oct 2008 16:31:11 +0000 (11:31 -0500)]
[parser] Handle special case of "New newline at end of file"
If a file doesn't have a newline at the end, diff will insert a "\ No
newline at end of file" line in the middle of the last hunk. parser.py
was counting this line as part of the hunk line count. This had the side
effect of putting the last line of the hunk in the patch comment, and
truncating out the last line of the diff.
Handle this special case by not including this line in the internal line
counter. This appears to be the only case where diff will insert a
string like this within a hunk.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 23 Oct 2008 03:22:33 +0000 (14:22 +1100)]
[parser] Handle patches with no content charset defined
If we don't have an incoming charset defined, assume utf-8.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 14 Oct 2008 02:30:05 +0000 (13:30 +1100)]
[parser] Convert patch content to unicode before parsing
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 08:27:24 +0000 (19:27 +1100)]
[packages] Fix bug with django 1.0
We needed an extra to_field_name
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 07:08:08 +0000 (18:08 +1100)]
[parser] Accept x-diff patches
We should accept x-diff attachments as well as x-patch.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 07:01:50 +0000 (18:01 +1100)]
[packages] update to django 1.0
With a minor code change, and a small workaround.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 01:00:56 +0000 (12:00 +1100)]
[docs] Create python and packages directories
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 9 Oct 2008 11:50:49 +0000 (22:50 +1100)]
[models] Fix exception on mbox view with non-ascii submitter name
We need to unicode the name instead of str-ing it.
Add test.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 9 Oct 2008 11:49:18 +0000 (22:49 +1100)]
[sql] use separate grant-all scripts for postgresql and mysql
Mysql doesn't support granting to multiple tables, and requires a
different username format.
Would be nice to code the permissions somewhere, then generate the
grant statements as required.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 7 Oct 2008 02:32:27 +0000 (13:32 +1100)]
[encoding] Don't output patch mbox as quoted-printable
git-am doesn't like quoted-printable, so output mbox files as raw 7- or
8-bit mbox files. This means we have to create a new MIMEText class, so
that the content isn't automatically QP-encoded on __init__().
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 13:29:37 +0000 (23:29 +1000)]
[models] Create patch mbox with utf-8 encoding
We were getting exceptions on the mbox view when looking at a
non-ascii patch.
Add test to suit.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 13:14:05 +0000 (23:14 +1000)]
[sql] Default data should be in fixtures, not custom SQL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 12:28:32 +0000 (22:28 +1000)]
[tests] Remove print from SenderCorrelationTest
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 12:27:51 +0000 (22:27 +1000)]
[tests] Add tests for utf-8 patches
.. which expose a bug in the patch parser, so fix that.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 23:17:00 +0000 (09:17 +1000)]
[views] Don't use bundle owner for current user
This made the top auth area show the bundle owner's details, not
the bundle owner's.
Bundle owner can still be accessed through bundle.owner in the template.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 07:29:36 +0000 (17:29 +1000)]
[html] Fix apparently-unclosed script tag
Firefox doesn't seem to grok the <script/> notation.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 07:27:20 +0000 (17:27 +1000)]
[html] Add select-all checkbox for patch lists
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 06:26:16 +0000 (16:26 +1000)]
[html] Reference common.js in base template
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 06:21:38 +0000 (16:21 +1000)]
[html] Consolidate js files
We don't need most of the stuff in htdocs/js/. Put the only function
required into a common.js, which we can add other stuff to.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 05:13:39 +0000 (15:13 +1000)]
[views] Change default ordering to latest-first
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 23 Sep 2008 12:03:35 +0000 (22:03 +1000)]
[css] Separate patchforms from list a little
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 23 Sep 2008 11:55:39 +0000 (21:55 +1000)]
[html] Reinstate 'about' link
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 23 Sep 2008 11:31:37 +0000 (21:31 +1000)]
[css] Remove horizontal scrollbar
We don't need to specify width on #title.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 23 Sep 2008 10:52:53 +0000 (20:52 +1000)]
[views] Restructure profile view, simplify bundle access
Make bundles more like todo lists - the list itself has its own page,
accessible from the top user links.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 05:31:32 +0000 (15:31 +1000)]
[views] Fix empty bundle showing entire project's patches
If a bundle is empty, we end up triggering the 'if not patches' check
in generic_list(), which repopulates the patch list with the current
project's patches.
So, check for None instead, and leave the patch list empty.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 04:41:43 +0000 (14:41 +1000)]
Add comment signoffs and acks to mbox text
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 04:11:49 +0000 (14:11 +1000)]
[test] Move helper functions into tests/utils.py
So that we can use them for other tests
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 03:28:54 +0000 (13:28 +1000)]
[models] Improve comment filter
We should be able to search on the patch_id faster.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 03:21:28 +0000 (13:21 +1000)]
[parser] Fix spacing for encoded headers
We need to join the fragments with a space.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 02:59:16 +0000 (12:59 +1000)]
[parser] Merge senders with different case
... and add tests
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 02:14:23 +0000 (12:14 +1000)]
[test] 2.4-ise test cases
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 02:13:58 +0000 (12:13 +1000)]
Add bin/__init__.py
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 02:09:10 +0000 (12:09 +1000)]
[parser] Decode From: headers
We're getting a few utf-8 encoded From: addresses, so decode before
saving to the DB.
Also, add tests.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 00:30:05 +0000 (10:30 +1000)]
[parser] Don't remove --- update lines
We'd like to keep update lines in the patch comments, so change the
signature-removal code to allow them to pass through.
Also, add appropriate tests.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 20 Sep 2008 00:11:38 +0000 (10:11 +1000)]
[test] Add test for signatures in comments
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 19 Sep 2008 08:10:52 +0000 (18:10 +1000)]
[test] Add patchwork testing infrastructure
Add a small set of initial tests for the patch parsing code.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 19 Sep 2008 08:01:11 +0000 (18:01 +1000)]
Remove superfluous print from parsemail.py
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 16 Sep 2008 10:06:54 +0000 (20:06 +1000)]
Fix handling of newlines in subjects
By doing two passes of whitespace normalisation
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 16 Sep 2008 07:39:50 +0000 (17:39 +1000)]
Drop project.linkname from patch subject lines
.. otherwise every cell patch will be prefixed with [Cbe-oss-dev]
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 16 Sep 2008 07:34:55 +0000 (17:34 +1000)]
Improve [PATCH] subject parsing
We'd like to leave some fragments of [PATCH]-style headers in the
patch subject, so add functionality to do this in clean_subject
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 16 Sep 2008 06:43:32 +0000 (16:43 +1000)]
Add 404 template
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 12 Sep 2008 01:07:52 +0000 (11:07 +1000)]
Fix 'activate' mispelling
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 12 Sep 2008 01:00:33 +0000 (11:00 +1000)]
Fix mishandling of existing querystring parameters
Currently, we only get the first character of order= parameters
in the 'remove this filter' querystring.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 12 Sep 2008 00:55:21 +0000 (10:55 +1000)]
Remember state filter settings
We need to set a few 'selected' options..
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 12 Sep 2008 00:41:27 +0000 (10:41 +1000)]
Don't apply delegate = Nobody filter by default
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 12 Sep 2008 00:28:02 +0000 (10:28 +1000)]
Make state = Action Required a default filter
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 12 Sep 2008 00:14:12 +0000 (10:14 +1000)]
Add 'Action Required' meta-state filter
This filter shows all patches in states with action_required = True.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 11 Sep 2008 07:15:35 +0000 (17:15 +1000)]
Save UserPersonConfirmations after activating
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 11 Sep 2008 07:11:29 +0000 (17:11 +1000)]
Save confirmation object before trying to render user-link email
We need the key, which is generated in save()
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Wed, 10 Sep 2008 22:14:33 +0000 (17:14 -0500)]
pwclient: Get rid of underscore to dash replacement
I was erroneously doing some string substitutions so that it
would find project names with an underscore in the name. It
was only necessary due to a side effect of a bug fixed in commit
35241d528c3699b982730a333e236d57dc6451b6 (find project by linkname,
not full name). In my test case, I had an underscore in the linkname,
but a dash in the full name.
No such string replacement is necessary, and actually breaks
filtering by projects with an underscore in the name now that
we're searching by linkname properly.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 11 Sep 2008 06:42:26 +0000 (16:42 +1000)]
Don't just rely on random for UserPersonConfirmation keys
It looks like we're getting identical keys generated for confirmation
keys. Problem has been reported to django, but in the meantime, salt
with the user and email details, then sha1 to give the final key.
This requires an increase in the field size for key, migration script
included.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 11 Sep 2008 05:53:08 +0000 (15:53 +1000)]
Add HashField.construct() method
To construct a new hash object for the given algorithm. While we're at
it, clean up the hashlib-wrapping code.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 03:21:39 +0000 (13:21 +1000)]
xmlrpc: Fix Python 2.4 compatibility in _marshaled_dispatch
Based on an original patch from Nate Case <ncase@xes-inc.com>.
Python 24 doesn't accept encoding and allow_none fields for
xmlrpclib.dumps, so abstract this function at dispatcher init time.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 03:20:29 +0000 (13:20 +1000)]
Simplify hashlib behaviour in HashField
We only need to keep the size of the field required, not the
whole hashlib constructor
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 02:08:01 +0000 (12:08 +1000)]
Allow pwclient to accept patch hashes
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 02:03:50 +0000 (12:03 +1000)]
Make parser.py invokation a little more flexible
Add options to control output, allowing us to use the parser to
generate patch hashes.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 02:02:50 +0000 (12:02 +1000)]
Allow rehash for specific patches
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 10 Sep 2008 01:21:19 +0000 (11:21 +1000)]
Use hex strings for hash values
Binary strings a too hard to manage in DB queries and XMLRPC methods,
as we get all kinds of encoding issues.
Change HashField to use a hex string, and add a migration script for db
updates. The patches should be rehashed after migration.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 08:19:19 +0000 (18:19 +1000)]
Add patch_get_by_hash method to XMLRPC interface
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 08:15:43 +0000 (18:15 +1000)]
Import hashlib in HashField.db_type
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Sep 2008 07:26:38 +0000 (17:26 +1000)]
Hook-up hashing infrastructure
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>