From: Eivind Næss <eivnaes@yahoo.com>
Date: Thu, 23 Sep 2021 14:49:40 +0000 (-0700)
Subject: Fixing CLang -Wpointer-sign warnings in sendserver.c
X-Git-Tag: ppp-2.5.0~56^2~6
X-Git-Url: https://git.ozlabs.org/?a=commitdiff_plain;h=afdcc8e741b3b3b478dbea34974e467f72050076;hp=6fbd9acc05bde03c1d6acfc8256d2bb411c0cc00;p=ppp.git

Fixing CLang -Wpointer-sign warnings in sendserver.c

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
---

diff --git a/pppd/plugins/radius/sendserver.c b/pppd/plugins/radius/sendserver.c
index d7bebdb..f601286 100644
--- a/pppd/plugins/radius/sendserver.c
+++ b/pppd/plugins/radius/sendserver.c
@@ -104,7 +104,7 @@ static int rc_pack_list (VALUE_PAIR *vp, char *secret, AUTH_HDR *auth)
 		    memcpy ((char *) passbuf, vp->strvalue, (size_t) length);
 
 		    secretlen = strlen (secret);
-		    vector = (char *)auth->vector;
+		    vector = auth->vector;
 		    for(i = 0; i < padded_length; i += AUTH_VECTOR_LEN) {
 			/* Calculate the MD5 digest*/
 			strcpy ((char *) md5buf, secret);
@@ -200,10 +200,10 @@ int rc_send_server (SEND_DATA *data, char *msg, REQUEST_INFO *info)
 	AUTH_HDR       *auth, *recv_auth;
 	UINT4           auth_ipaddr;
 	char           *server_name;	/* Name of server to query */
-	int             salen;
+	socklen_t       salen;
 	int             result;
 	int             total_length;
-	int             length;
+	socklen_t       length;
 	int             retry_max;
 	int		secretlen;
 	char            secret[MAX_SECRET_LENGTH + 1];
@@ -273,7 +273,7 @@ int rc_send_server (SEND_DATA *data, char *msg, REQUEST_INFO *info)
 		memset((char *) auth->vector, 0, AUTH_VECTOR_LEN);
 		secretlen = strlen (secret);
 		memcpy ((char *) auth + total_length, secret, secretlen);
-		rc_md5_calc (vector, (char *) auth, total_length + secretlen);
+		rc_md5_calc (vector, (unsigned char *) auth, total_length + secretlen);
 		memcpy ((char *) auth->vector, (char *) vector, AUTH_VECTOR_LEN);
 	}
 	else
@@ -363,7 +363,7 @@ int rc_send_server (SEND_DATA *data, char *msg, REQUEST_INFO *info)
 	{
 		if ((vp = rc_avpair_get(vp, PW_REPLY_MESSAGE)))
 		{
-			strcat(msg, vp->strvalue);
+			strcat(msg, (char*) vp->strvalue);
 			strcat(msg, "\n");
 			vp = vp->next;
 		}
@@ -429,7 +429,7 @@ static int rc_check_reply (AUTH_HDR *auth, int bufferlen, char *secret,
 	memcpy ((char *) reply_digest, (char *) auth->vector, AUTH_VECTOR_LEN);
 	memcpy ((char *) auth->vector, (char *) vector, AUTH_VECTOR_LEN);
 	memcpy ((char *) auth + totallen, secret, secretlen);
-	rc_md5_calc (calc_digest, (char *) auth, totallen + secretlen);
+	rc_md5_calc (calc_digest, (unsigned char *) auth, totallen + secretlen);
 
 #ifdef DIGEST_DEBUG
 	{