From: David Gibson <david@gibson.dropbear.id.au>
Date: Sun, 2 Apr 2017 15:15:53 +0000 (+1000)
Subject: net: Add check for failure of setsockopt()
X-Git-Url: https://git.ozlabs.org/?a=commitdiff_plain;h=5c1767485d0879cdacdfeed218f5e91cc2e9f716;hp=6251b771b31cfd121efe32d08fe9b2a56546b17b;p=ccan

net: Add check for failure of setsockopt()

make_listen_fd() didn't check for failure of setsockopt().  There's no
real reason not to, since we have an obvious way to report an error to the
caller.

Found with Coverity Scan.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---

diff --git a/ccan/net/net.c b/ccan/net/net.c
index e9199839..11c6b670 100644
--- a/ccan/net/net.c
+++ b/ccan/net/net.c
@@ -238,7 +238,9 @@ static int make_listen_fd(const struct addrinfo *addrinfo)
 	if (fd < 0)
 		return -1;
 
-	setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
+	if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) != 0)
+		goto fail;
+
 	if (bind(fd, addrinfo->ai_addr, addrinfo->ai_addrlen) != 0)
 		goto fail;