From: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon, 9 Jan 2023 02:07:22 +0000 (+1030)
Subject: ccanlint: fix use-after-free in verbose mode.
X-Git-Url: https://git.ozlabs.org/?a=commitdiff_plain;h=523944ee598bfd43b2d2b944ee5b1cd2c7cc18ed;hp=ab87e56bec6a8727a1bbfae7858fb5b0122539a7;p=ccan

ccanlint: fix use-after-free in verbose mode.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---

diff --git a/tools/read_config_header.c b/tools/read_config_header.c
index da9ed0a3..da3e00cd 100644
--- a/tools/read_config_header.c
+++ b/tools/read_config_header.c
@@ -96,10 +96,11 @@ char *read_config_header(const char *ccan_dir, bool verbose)
 	char *config_header;
 
 	config_header = grab_file(NULL, fname);
-	tal_free(fname);
 
-	if (!config_header)
+	if (!config_header) {
+		tal_free(fname);
 		return NULL;
+	}
 
 	lines = tal_strsplit(config_header, config_header, "\n", STR_EMPTY_OK);
 	for (i = 0; i < tal_count(lines) - 1; i++) {
@@ -129,5 +130,6 @@ char *read_config_header(const char *ccan_dir, bool verbose)
 				       fname, cflags);
 		}
 	}
+	tal_free(fname);
 	return config_header;
 }