From: Rusty Russell <rusty@rustcorp.com.au>
Date: Tue, 14 Jul 2009 02:20:26 +0000 (+0930)
Subject: More dependency optimization: seems to happen with transactions enabled.
X-Git-Url: https://git.ozlabs.org/?a=commitdiff_plain;h=46fc04374fd1ad3d1f3ff44e39e08cea16688c66;p=ccan

More dependency optimization: seems to happen with transactions enabled.
---

diff --git a/ccan/tdb/tools/replay_trace.c b/ccan/tdb/tools/replay_trace.c
index f9552b92..0d53f1fe 100644
--- a/ccan/tdb/tools/replay_trace.c
+++ b/ccan/tdb/tools/replay_trace.c
@@ -1165,8 +1165,10 @@ static void add_dependency(void *ctx,
 	unsigned int needs_start, sat_start;
 
 	/* We don't depend on ourselves. */
-	if (needs_file == satisfies_file)
+	if (needs_file == satisfies_file) {
+		assert(satisfies_opnum < needs_opnum);
 		return;
+	}
 
 #if DEBUG_DEPS
 	printf("%s:%u: depends on %s:%u\n",
@@ -1319,6 +1321,29 @@ static void optimize_dependencies(struct op *op[], unsigned int num_ops[],
 {
 	unsigned int i, j;
 
+	/* There can only be one real dependency on each file */
+	for (i = 0; i < num; i++) {
+		for (j = 1; j < num_ops[i]; j++) {
+			struct depend *dep, *next;
+			struct depend *prev[num];
+
+			memset(prev, 0, sizeof(prev));
+
+			list_for_each_safe(&op[i][j].pre, dep, next, pre_list) {
+				if (!prev[dep->satisfies_file]) {
+					prev[dep->satisfies_file] = dep;
+					continue;
+				}
+				if (prev[dep->satisfies_file]->satisfies_opnum
+				    > dep->satisfies_opnum) {
+					talloc_free(prev[dep->satisfies_file]);
+					prev[dep->satisfies_file] = dep;
+				} else
+					talloc_free(dep);
+			}
+		}
+	}
+
 	for (i = 0; i < num; i++) {
 		int deps[num];