From: Paul Mackerras <paulus@ozlabs.org>
Date: Sat, 23 Jun 2018 06:40:27 +0000 (+1000)
Subject: pppd: Fix compile warning due to comparing pointer to NUL character
X-Git-Tag: ppp-2.4.8~35
X-Git-Url: https://git.ozlabs.org/?a=commitdiff_plain;h=292c35d97edb6eca5f7af7aae31488cca2c2ca6f;hp=3b409a8e299446e3118743ff2508c54330011eeb;p=ppp.git

pppd: Fix compile warning due to comparing pointer to NUL character

Evidently this means to check for arg pointing to an empty string,
not arg being NULL, since the ensuing error talks about the variable
name being missing.

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
---

diff --git a/pppd/options.c b/pppd/options.c
index 482dce6..5db580a 100644
--- a/pppd/options.c
+++ b/pppd/options.c
@@ -1753,7 +1753,7 @@ user_unsetenv(argv)
 	option_error("unexpected = in name: %s", arg);
 	return 0;
     }
-    if (arg == '\0') {
+    if (*arg == '\0') {
 	option_error("missing variable name for unset");
 	return 0;
     }