Clang says this:
discover/device-handler.c:1564:27: warning: size argument in 'strncmp' call is a comparison [-Wmemsize-comparison]
strlen(opt->version) == 0)) {
~~~~~~~~~~~~~~~~~~~~~^~~~
discover/device-handler.c:1563:5: note: did you mean to compare the result of 'strncmp' instead?
strncmp(opt->version, tmp->version,
^
It looks like it's correct. However, we can go one better and drop the
pointless strncmp(foo, bar, strlen(bar)), as this is equivalent to
strcmp(foo, bar).
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
tmp = handler->plugins[i];
/* If both id and version match, ignore */
if (strncmp(opt->id, tmp->id, strlen(opt->id)) == 0 &&
tmp = handler->plugins[i];
/* If both id and version match, ignore */
if (strncmp(opt->id, tmp->id, strlen(opt->id)) == 0 &&
- strncmp(opt->version, tmp->version,
- strlen(opt->version) == 0)) {
+ strcmp(opt->version, tmp->version) == 0) {
pb_log("discover: Plugin '%s' already exists, ignoring\n",
opt->id);
return;
pb_log("discover: Plugin '%s' already exists, ignoring\n",
opt->id);
return;