X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=ui%2Fncurses%2Fnc-boot-editor.c;h=a1b752f82f28f3c19ee294215fc1209ff91cdb24;hb=97c851090d74ef0a465464145cbe3a8a43cba547;hp=8fe33656441d07a24c5be75dc8332a96b13c52b7;hpb=6d1eff1e8e1db12e7aa179e8dc9c65050c045536;p=petitboot

diff --git a/ui/ncurses/nc-boot-editor.c b/ui/ncurses/nc-boot-editor.c
index 8fe3365..a1b752f 100644
--- a/ui/ncurses/nc-boot-editor.c
+++ b/ui/ncurses/nc-boot-editor.c
@@ -26,6 +26,38 @@
 #include "log/log.h"
 #include "talloc/talloc.h"
 #include "nc-boot-editor.h"
+#include "nc-widgets.h"
+
+struct boot_editor {
+	struct nc_scr		scr;
+	struct cui		*cui;
+	void			*data;
+	struct pmenu_item	*item;
+	void			(*on_exit)(struct cui *cui,
+					struct pmenu_item *item,
+					struct pb_boot_data *bd);
+
+	int			label_x;
+	int			field_x;
+
+	struct nc_widgetset	*widgetset;
+	struct {
+		struct nc_widget_label		*device_l;
+		struct nc_widget_select		*device_f;
+		struct nc_widget_label		*image_l;
+		struct nc_widget_textbox	*image_f;
+		struct nc_widget_label		*initrd_l;
+		struct nc_widget_textbox	*initrd_f;
+		struct nc_widget_label		*dtb_l;
+		struct nc_widget_textbox	*dtb_f;
+		struct nc_widget_label		*args_l;
+		struct nc_widget_textbox	*args_f;
+		struct nc_widget_button		*ok_b;
+		struct nc_widget_button		*cancel_b;
+	} widgets;
+
+	const char		*selected_device;
+};
 
 static struct boot_editor *boot_editor_from_scr(struct nc_scr *scr)
 {
@@ -46,88 +78,12 @@ static struct boot_editor *boot_editor_from_arg(void *arg)
 	return boot_editor;
 }
 
-/**
- * boot_editor_move_cursor - Move the cursor, setting correct attributes.
- * @req: An ncurses request or char to send to form_driver().
- */
-
-static int boot_editor_move_cursor(struct boot_editor *boot_editor, int req)
-{
-	int result;
-
-	wchgat(boot_editor->scr.sub_ncw, 1,
-			boot_editor_attr_field_selected, 0, 0);
-	result = form_driver(boot_editor->ncf, req);
-	wchgat(boot_editor->scr.sub_ncw, 1, boot_editor->attr_cursor, 0, 0);
-	wrefresh(boot_editor->scr.main_ncw);
-	return result;
-}
-
-/**
- * boot_editor_insert_mode_set - Set the insert mode.
- */
-
-static void boot_editor_insert_mode_set(struct boot_editor *boot_editor,
-		int req)
-{
-	switch (req) {
-	case REQ_INS_MODE:
-		boot_editor->attr_cursor = boot_editor_attr_cursor_ins;
-		break;
-	case REQ_OVL_MODE:
-		boot_editor->attr_cursor = boot_editor_attr_cursor_ovl;
-		break;
-	default:
-		assert(0 && "bad req");
-		break;
-	}
-	boot_editor_move_cursor(boot_editor, req);
-}
-
-/**
- * boot_editor_insert_mode_tog - Toggle the insert mode.
- */
-
-static void boot_editor_insert_mode_tog(struct boot_editor *boot_editor)
-{
-	if (boot_editor->attr_cursor == boot_editor_attr_cursor_ins)
-		boot_editor_insert_mode_set(boot_editor, REQ_OVL_MODE);
-	else
-		boot_editor_insert_mode_set(boot_editor, REQ_INS_MODE);
-}
-
-/**
- * boot_editor_move_field - Move selected field, setting correct attributes.
- * @req: An ncurses request to send to form_driver().
- */
-
-static int boot_editor_move_field(struct boot_editor *boot_editor, int req)
-{
-	int result;
-
-	set_field_back(current_field(boot_editor->ncf),
-			boot_editor_attr_field_normal);
-
-	result = form_driver(boot_editor->ncf, req);
-
-	set_field_back(current_field(boot_editor->ncf),
-			boot_editor_attr_field_selected);
-
-	boot_editor_move_cursor(boot_editor, REQ_END_FIELD);
-	return result;
-}
-
 static int boot_editor_post(struct nc_scr *scr)
 {
 	struct boot_editor *boot_editor = boot_editor_from_scr(scr);
 
-	post_form(boot_editor->ncf);
-
+	widgetset_post(boot_editor->widgetset);
 	nc_scr_frame_draw(scr);
-	boot_editor_move_field(boot_editor, REQ_FIRST_FIELD);
-	boot_editor_move_field(boot_editor, REQ_END_FIELD);
-	boot_editor_insert_mode_set(boot_editor, REQ_INS_MODE);
-
 	redrawwin(boot_editor->scr.main_ncw);
 	wrefresh(boot_editor->scr.main_ncw);
 
@@ -136,7 +92,13 @@ static int boot_editor_post(struct nc_scr *scr)
 
 static int boot_editor_unpost(struct nc_scr *scr)
 {
-	return unpost_form(boot_editor_from_scr(scr)->ncf);
+	widgetset_unpost(boot_editor_from_scr(scr)->widgetset);
+	return 0;
+}
+
+struct nc_scr *boot_editor_scr(struct boot_editor *boot_editor)
+{
+	return &boot_editor->scr;
 }
 
 static void boot_editor_resize(struct nc_scr *scr)
@@ -146,50 +108,52 @@ static void boot_editor_resize(struct nc_scr *scr)
 	boot_editor_post(scr);
 }
 
-/**
- * boot_editor_chomp - Eat leading and trailing WS.
- */
-
-static char *boot_editor_chomp(char *s)
+static char *conditional_prefix(struct pb_boot_data *ctx,
+		const char *prefix, const char *value)
 {
-	char *start;
-	char *end;
-	char *const s_end = s + strlen(s);
+	const char *sep;
 
-	for (; s < s_end; s++)
-		if (*s != ' ' && *s != '\t')
-			break;
+	if (!value || !*value)
+		return NULL;
 
-	start = end = s;
+	sep = NULL;
+	if (!prefix)
+		prefix = "";
+	else if (prefix[strlen(prefix)] != '/')
+		sep = "/";
 
-	for (; s < s_end; s++)
-		if (*s != ' ' && *s != '\t')
-			end = s;
-	*(end + 1) = 0;
-	return start;
+	return talloc_asprintf(ctx, "%s%s%s", prefix, sep, value);
 }
 
 static struct pb_boot_data *boot_editor_prepare_data(
 		struct boot_editor *boot_editor)
 {
 	struct pb_boot_data *bd;
-	char *s;
+	char *s, *prefix;
+	int idx;
 
 	bd = talloc(boot_editor, struct pb_boot_data);
 
 	if (!bd)
 		return NULL;
 
-	s = boot_editor_chomp(field_buffer(boot_editor->fields[0], 0));
-	bd->image = *s ? talloc_strdup(bd, s) : NULL;
+	idx = widget_select_get_value(boot_editor->widgets.device_f);
+	if (idx == -1 || (unsigned int)idx >
+			boot_editor->cui->sysinfo->n_blockdevs)
+		prefix = NULL;
+	else
+		prefix = boot_editor->cui->sysinfo->blockdevs[idx]->mountpoint;
+
+	s = widget_textbox_get_value(boot_editor->widgets.image_f);
+	bd->image = conditional_prefix(bd, prefix, s);
 
-	s = boot_editor_chomp(field_buffer(boot_editor->fields[1], 0));
-	bd->initrd = *s ? talloc_strdup(bd, s) : NULL;
+	s = widget_textbox_get_value(boot_editor->widgets.initrd_f);
+	bd->initrd = conditional_prefix(bd, prefix, s);
 
-	s = boot_editor_chomp(field_buffer(boot_editor->fields[2], 0));
-	bd->dtb = *s ? talloc_strdup(bd, s) : NULL;
+	s = widget_textbox_get_value(boot_editor->widgets.dtb_f);
+	bd->dtb = conditional_prefix(bd, prefix, s);
 
-	s = boot_editor_chomp(field_buffer(boot_editor->fields[3], 0));
+	s = widget_textbox_get_value(boot_editor->widgets.args_f);
 	bd->args = *s ? talloc_strdup(bd, s) : NULL;
 
 	return bd;
@@ -204,67 +168,19 @@ static struct pb_boot_data *boot_editor_prepare_data(
 static void boot_editor_process_key(struct nc_scr *scr, int key)
 {
 	struct boot_editor *boot_editor = boot_editor_from_scr(scr);
-	struct pb_boot_data *bd;
+	bool handled;
 
-	switch (key) {
-	default:
-		boot_editor_move_cursor(boot_editor, key);
-		break;
+	handled = widgetset_process_key(boot_editor->widgetset, key);
+	if (handled) {
+		wrefresh(boot_editor->scr.main_ncw);
+		return;
+	}
 
-	/* hot keys */
+	switch (key) {
+	case 'x':
 	case 27: /* ESC */
-		boot_editor->on_exit(boot_editor, boot_editor_cancel, NULL);
+		boot_editor->on_exit(boot_editor->cui, NULL, NULL);
 		nc_flush_keys();
-		return;
-	case '\n':
-	case '\r':
-		form_driver(boot_editor->ncf, REQ_VALIDATION);
-		bd = boot_editor_prepare_data(boot_editor);
-		boot_editor->on_exit(boot_editor, boot_editor_update, bd);
-		nc_flush_keys();
-		return;
-
-	/* insert mode */
-	case KEY_IC:
-		boot_editor_insert_mode_tog(boot_editor);
-		break;
-
-	/* form nav */
-	case KEY_PPAGE:
-		boot_editor_move_field(boot_editor, REQ_FIRST_FIELD);
-		break;
-	case KEY_NPAGE:
-		boot_editor_move_field(boot_editor, REQ_LAST_FIELD);
-		break;
-	case KEY_DOWN:
-		boot_editor_move_field(boot_editor, REQ_NEXT_FIELD);
-		break;
-	case KEY_UP:
-		boot_editor_move_field(boot_editor, REQ_PREV_FIELD);
-		break;
-
-	/* field nav */
-	case KEY_HOME:
-		boot_editor_move_cursor(boot_editor, REQ_BEG_FIELD);
-		break;
-	case KEY_END:
-		boot_editor_move_cursor(boot_editor, REQ_END_FIELD);
-		break;
-	case KEY_LEFT:
-		boot_editor_move_cursor(boot_editor, REQ_LEFT_CHAR);
-		break;
-	case KEY_RIGHT:
-		boot_editor_move_cursor(boot_editor, REQ_RIGHT_CHAR);
-		break;
-	case KEY_BACKSPACE:
-		if (boot_editor_move_cursor(boot_editor, REQ_LEFT_CHAR)
-				== E_OK)
-			boot_editor_move_cursor(boot_editor,
-					REQ_DEL_CHAR);
-		break;
-	case KEY_DC:
-		boot_editor_move_cursor(boot_editor, REQ_DEL_CHAR);
-		break;
 	}
 }
 
@@ -275,73 +191,149 @@ static void boot_editor_process_key(struct nc_scr *scr, int key)
 static int boot_editor_destructor(void *arg)
 {
 	struct boot_editor *boot_editor = boot_editor_from_arg(arg);
-	FIELD **f;
+	boot_editor->scr.sig = pb_removed_sig;
+	return 0;
+}
 
-	for (f = boot_editor->fields; *f; f++)
-		free_field(*f);
+static void ok_click(void *arg)
+{
+	struct boot_editor *boot_editor = arg;
+	struct pb_boot_data *bd;
 
-	free_form(boot_editor->ncf);
-	boot_editor->scr.sig = pb_removed_sig;
+	bd = boot_editor_prepare_data(boot_editor);
+	boot_editor->on_exit(boot_editor->cui, boot_editor->item, bd);
+}
 
-	return 0;
+static void cancel_click(void *arg)
+{
+	struct boot_editor *boot_editor = arg;
+	boot_editor->on_exit(boot_editor->cui, NULL, NULL);
 }
 
-static FIELD *boot_editor_setup_field(unsigned int y, unsigned int x, char *str)
+static int layout_pair(struct boot_editor *boot_editor, int y,
+		struct nc_widget_label *label,
+		struct nc_widget_textbox *field)
 {
-	FIELD *f;
-
-	f = new_field(1, COLS - 1 - x, y, x, 0, 0);
-	field_opts_off(f, O_STATIC | O_WRAP);
-	set_max_field(f, 256);
-	set_field_buffer(f, 0, str);
-	set_field_status(f, 0);
-	return f;
+	struct nc_widget *label_w = widget_label_base(label);
+	struct nc_widget *field_w = widget_textbox_base(field);
+	widget_move(label_w, y, boot_editor->label_x);
+	widget_move(field_w, y, boot_editor->field_x);
+	return max(widget_height(label_w), widget_height(field_w));
 }
 
-static FIELD *boot_editor_setup_label(unsigned int y, unsigned int x, char *str)
+static void boot_editor_layout_widgets(struct boot_editor *boot_editor)
 {
-	FIELD *f;
+	struct nc_widget *wf, *wl;
+	int y = 1;
+
+	wl = widget_label_base(boot_editor->widgets.device_l);
+	wf = widget_select_base(boot_editor->widgets.device_f);
+	widget_move(wl, y, boot_editor->label_x);
+	widget_move(wf, y, boot_editor->field_x);
+
+	y += widget_height(wf) + 1;
+
+
+	y += layout_pair(boot_editor, y, boot_editor->widgets.image_l,
+					 boot_editor->widgets.image_f);
+
+	y += layout_pair(boot_editor, y, boot_editor->widgets.initrd_l,
+					 boot_editor->widgets.initrd_f);
 
-	f = new_field(1, strlen(str), y, x, 0, 0);
-	field_opts_off(f, O_ACTIVE);
-	set_field_buffer(f, 0, str);
-	return f;
+	y += layout_pair(boot_editor, y, boot_editor->widgets.dtb_l,
+					 boot_editor->widgets.dtb_f);
+
+	y += layout_pair(boot_editor, y, boot_editor->widgets.args_l,
+					 boot_editor->widgets.args_f);
+
+
+	y++;
+	widget_move(widget_button_base(boot_editor->widgets.ok_b), y, 9);
+	widget_move(widget_button_base(boot_editor->widgets.cancel_b), y, 19);
 }
 
-struct boot_editor *boot_editor_init(struct pmenu *menu,
-		const struct pb_boot_data *bd,
-		void (*on_exit)(struct boot_editor *,
-				enum boot_editor_result,
-				struct pb_boot_data *))
+static void boot_editor_device_select_change(void *arg, int idx)
+{
+	struct boot_editor *boot_editor = arg;
+	if (idx == -1)
+		boot_editor->selected_device = NULL;
+	else
+		boot_editor->selected_device =
+			boot_editor->cui->sysinfo->blockdevs[idx]->name;
+}
+
+static void boot_editor_populate_device_select(struct boot_editor *boot_editor,
+		const struct system_info *sysinfo)
+{
+	struct nc_widget_select *select = boot_editor->widgets.device_f;
+	unsigned int i;
+	bool selected;
+
+	widget_select_drop_options(select);
+
+	for (i = 0; i < sysinfo->n_blockdevs; i++) {
+		struct blockdev_info *bd_info = sysinfo->blockdevs[i];
+		const char *name;
+
+		name = talloc_asprintf(boot_editor, "%s [%s]",
+				bd_info->name, bd_info->uuid);
+		selected = boot_editor->selected_device &&
+				!strcmp(bd_info->name,
+						boot_editor->selected_device);
+
+		widget_select_add_option(boot_editor->widgets.device_f,
+				i, name, selected);
+	}
+
+	/* If we're editing an existing option, the paths will be fully-
+	 * resolved. In this case, we want the manual device pre-selected.
+	 * However, we only do this if the widget hasn't been manually
+	 * changed. */
+	selected = boot_editor->item && !boot_editor->selected_device;
+
+	widget_select_add_option(boot_editor->widgets.device_f,
+			-1, "Specify paths/URLs manually", selected);
+}
+
+struct boot_editor *boot_editor_init(struct cui *cui,
+		struct pmenu_item *item,
+		const struct system_info *sysinfo,
+		void (*on_exit)(struct cui *cui,
+				struct pmenu_item *item,
+				struct pb_boot_data *bd))
 {
 	char *image, *initrd, *dtb, *args;
 	struct boot_editor *boot_editor;
+	struct nc_widgetset *set;
+	int field_size;
 
-	assert(on_exit);
+	(void)sysinfo;
 
-	boot_editor = talloc_zero(menu, struct boot_editor);
+	boot_editor = talloc_zero(cui, struct boot_editor);
 
 	if (!boot_editor)
 		return NULL;
 
 	talloc_set_destructor(boot_editor, boot_editor_destructor);
-	boot_editor->original_pmenu = menu;
+	boot_editor->cui = cui;
+	boot_editor->item = item;
+	boot_editor->on_exit = on_exit;
+
+	boot_editor->label_x = 1;
+	boot_editor->field_x = 9;
 
 	nc_scr_init(&boot_editor->scr, pb_boot_editor_sig, 0,
-			menu, boot_editor_process_key,
+			cui, boot_editor_process_key,
 		boot_editor_post, boot_editor_unpost, boot_editor_resize);
 
 	boot_editor->scr.frame.ltitle = talloc_strdup(boot_editor,
 			"Petitboot Option Editor");
 	boot_editor->scr.frame.rtitle = NULL;
 	boot_editor->scr.frame.help = talloc_strdup(boot_editor,
-			"ESC=cancel, Enter=accept");
-
-	boot_editor->on_exit = on_exit;
-
-	boot_editor->fields = talloc_array(boot_editor, FIELD *, 9);
+			"Enter=accept");
 
-	if (bd) {
+	if (item) {
+		struct pb_boot_data *bd = cod_from_item(item)->bd;
 		image = bd->image;
 		initrd = bd->initrd;
 		dtb = bd->dtb;
@@ -350,20 +342,42 @@ struct boot_editor *boot_editor_init(struct pmenu *menu,
 		image = initrd = dtb = args = "";
 	}
 
-	boot_editor->fields[0] = boot_editor_setup_field(0, 9, image);
-	boot_editor->fields[1] = boot_editor_setup_field(1, 9, initrd);
-	boot_editor->fields[2] = boot_editor_setup_field(2, 9, dtb);
-	boot_editor->fields[3] = boot_editor_setup_field(3, 9, args);
-	boot_editor->fields[4] = boot_editor_setup_label(0, 1, "image:");
-	boot_editor->fields[5] = boot_editor_setup_label(1, 1, "initrd:");
-	boot_editor->fields[6] = boot_editor_setup_label(2, 1, "dtb:");
-	boot_editor->fields[7] = boot_editor_setup_label(3, 1, "args:");
-	boot_editor->fields[8] = NULL;
+	field_size = COLS - 1 - boot_editor->field_x;
+
+	boot_editor->widgetset = set = widgetset_create(boot_editor,
+			boot_editor->scr.main_ncw,
+			boot_editor->scr.sub_ncw);
+
+	boot_editor->widgets.device_l = widget_new_label(set, 0, 0, "device:");
+	boot_editor->widgets.device_f = widget_new_select(set, 0, 0,
+						field_size);
+	widget_select_on_change(boot_editor->widgets.device_f,
+			boot_editor_device_select_change, boot_editor);
+
+	boot_editor_populate_device_select(boot_editor, sysinfo);
+
+	boot_editor->widgets.image_l = widget_new_label(set, 0, 0, "image:");
+	boot_editor->widgets.image_f = widget_new_textbox(set, 0, 0,
+						field_size, image);
+
+	boot_editor->widgets.initrd_l = widget_new_label(set, 0, 0, "initrd:");
+	boot_editor->widgets.initrd_f = widget_new_textbox(set, 0, 0,
+						field_size, initrd);
+
+	boot_editor->widgets.dtb_l = widget_new_label(set, 0, 0, "dtb:");
+	boot_editor->widgets.dtb_f = widget_new_textbox(set, 0, 0,
+						field_size, dtb);
+
+	boot_editor->widgets.args_l = widget_new_label(set, 0, 0, "args:");
+	boot_editor->widgets.args_f = widget_new_textbox(set, 0, 0,
+					field_size, args);
 
-	boot_editor->ncf = new_form(boot_editor->fields);
+	boot_editor->widgets.ok_b = widget_new_button(set, 0, 0, 6,
+					"OK", ok_click, boot_editor);
+	boot_editor->widgets.cancel_b = widget_new_button(set, 0, 0, 6,
+					"Cancel", cancel_click, boot_editor);
 
-	set_form_win(boot_editor->ncf, boot_editor->scr.main_ncw);
-	set_form_sub(boot_editor->ncf, boot_editor->scr.sub_ncw);
+	boot_editor_layout_widgets(boot_editor);
 
 	return boot_editor;
 }