X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Ftests_pass_valgrind.c;h=f17fbca4f9b7fa633e1c6e2a045d36f5284586c7;hb=5bfb3995da36408ded842c36052a5eadd602c431;hp=da61dd364729daf87c42cbeb91fbe184e9069e0b;hpb=c6c779398e42756a7cb1c566e8fd23b955c4775f;p=ccan

diff --git a/tools/ccanlint/tests/tests_pass_valgrind.c b/tools/ccanlint/tests/tests_pass_valgrind.c
index da61dd36..f17fbca4 100644
--- a/tools/ccanlint/tests/tests_pass_valgrind.c
+++ b/tools/ccanlint/tests/tests_pass_valgrind.c
@@ -127,7 +127,7 @@ static void do_run_tests_vg(struct manifest *m,
 				i->leak_info = get_leaks(output, &err);
 			}
 			if (err)
-				score_file_error(score, i, 0, err);
+				score_file_error(score, i, 0, "%s", err);
 			else
 				score->score++;
 		}
@@ -149,15 +149,17 @@ static void do_leakcheck_vg(struct manifest *m,
 	foreach_ptr(list, &m->run_tests, &m->api_tests) {
 		list_for_each(list, i, list) {
 			if (i->leak_info) {
-				score_file_error(score, i, 0, i->leak_info);
+				score_file_error(score, i, 0, "%s",
+						 i->leak_info);
 				leaks = true;
 			}
 		}
 	}
 
+	/* FIXME: We don't fail for this, since many tests leak. */ 
+	score->pass = true;
 	if (!leaks) {
 		score->score = 1;
-		score->pass = true;
 	}
 }