X-Git-Url: https://git.ozlabs.org/?a=blobdiff_plain;f=tools%2Fccanlint%2Ftests%2Flicense_exists.c;h=6305d61c02881a7fef67780d58067f1c80a2c9b0;hb=10e5e329a1a8804ff6461e1724071364cf6be572;hp=1ae27dd35266e6a7ca1fd9f55626dae69587a37e;hpb=db43894721895d0ec0a8e599440a9897136bfcb6;p=ccan diff --git a/tools/ccanlint/tests/license_exists.c b/tools/ccanlint/tests/license_exists.c index 1ae27dd3..6305d61c 100644 --- a/tools/ccanlint/tests/license_exists.c +++ b/tools/ccanlint/tests/license_exists.c @@ -11,63 +11,72 @@ #include #include -REGISTER_TEST(license_exists); - -static struct doc_section *find_license(const struct manifest *m) +/* We might need more ../ for nested modules. */ +static const char *link_prefix(struct manifest *m) { - struct doc_section *d; + char *prefix = talloc_strdup(m, "../../"); + unsigned int i; - list_for_each(m->info_file->doc_sections, d, list) { - if (!streq(d->function, m->basename)) - continue; - if (streq(d->type, "license")) - return d; - } - return NULL; + for (i = 0; i < strcount(m->modname, "/"); i++) + prefix = talloc_append_string(prefix, "../"); + + return talloc_append_string(prefix, "licenses/"); } -static const char *expected_link(const struct manifest *m, - struct doc_section *d) +static const char *expected_link(const char *prefix, enum license license) { - if (streq(d->lines[0], "GPL") - || streq(d->lines[0], "GPLv3") - || streq(d->lines[0], "GPLv3 or later") - || streq(d->lines[0], "GPLv3 (or later)") - || streq(d->lines[0], "GPL (3 or any later version)")) - return "../../licenses/GPL-3"; - if (streq(d->lines[0], "GPLv2") - || streq(d->lines[0], "GPLv2 or later") - || streq(d->lines[0], "GPLv2 (or later)") - || streq(d->lines[0], "GPL (2 or any later version)")) - return "../../licenses/GPL-3"; - if (streq(d->lines[0], "LGPL") - || streq(d->lines[0], "LGPLv3") - || streq(d->lines[0], "LGPLv3 or later") - || streq(d->lines[0], "LGPLv3 (or later)") - || streq(d->lines[0], "LGPL (3 or any later version)")) - return "../../licenses/LGPL-3"; - if (streq(d->lines[0], "LGPLv2") - || streq(d->lines[0], "LGPLv2 or later") - || streq(d->lines[0], "LGPLv2 (or later)") - || streq(d->lines[0], "LGPL (2 or any later version)")) - return "../../licenses/LGPL-2.1"; - if (streq(d->lines[0], "BSD") - || streq(d->lines[0], "BSD-MIT") - || streq(d->lines[0], "MIT")) - return "../../licenses/BSD-MIT"; - return NULL; + const char *shortname; + + switch (license) { + case LICENSE_LGPLv2_PLUS: + case LICENSE_LGPLv2: + shortname = "LGPL-2.1"; + break; + case LICENSE_LGPLv3: + case LICENSE_LGPL: + shortname = "LGPL-3"; + break; + + case LICENSE_GPLv2_PLUS: + case LICENSE_GPLv2: + shortname = "GPL-2"; + break; + + case LICENSE_GPLv3: + case LICENSE_GPL: + shortname = "GPL-3"; + break; + + case LICENSE_BSD: + shortname = "BSD-3CLAUSE"; + break; + + case LICENSE_MIT: + shortname = "BSD-MIT"; + break; + + case LICENSE_CC0: + shortname = "CC0"; + break; + + default: + return NULL; + } + + return talloc_append_string(talloc_strdup(prefix, prefix), shortname); } static void handle_license_link(struct manifest *m, struct score *score) { + struct doc_section *d = find_license_tag(m); + const char *prefix = link_prefix(m); const char *link = talloc_asprintf(m, "%s/LICENSE", m->dir); - struct doc_section *d = find_license(m); - const char *ldest = expected_link(m, d); + const char *ldest = expected_link(prefix, m->license); char *q; printf( "Most modules want a copy of their license, so usually we create a\n" - "LICENSE symlink into ../../licenses to avoid too many copies.\n"); + "LICENSE symlink into %s to avoid too many copies.\n", prefix); /* FIXME: make ask printf-like */ q = talloc_asprintf(m, "Set up link to %s (license is %s)?", @@ -78,8 +87,9 @@ static void handle_license_link(struct manifest *m, struct score *score) } } +extern struct ccanlint license_exists; + static void check_has_license(struct manifest *m, - bool keep, unsigned int *timeleft, struct score *score) { char buf[PATH_MAX]; @@ -87,20 +97,35 @@ static void check_has_license(struct manifest *m, char *license = talloc_asprintf(m, "%s/LICENSE", m->dir); const char *expected; struct doc_section *d; + const char *prefix = link_prefix(m); - d = find_license(m); + d = find_license_tag(m); if (!d) { score->error = talloc_strdup(score, "No License: tag in _info"); return; } - expected = expected_link(m, d); + + m->license = which_license(d); + if (m->license == LICENSE_UNKNOWN) { + score_file_error(score, m->info_file, d->srcline, + "WARNING: unknown License: in _info: %s", + d->lines[0]); + /* FIXME: For historical reasons, don't fail here. */ + score->pass = true; + return; + } + + /* If they have a license tag at all, we pass. */ + score->pass = true; + + expected = expected_link(prefix, m->license); len = readlink(license, buf, sizeof(buf)); if (len < 0) { /* Could be a real file... OK if not a standard license. */ if (errno == EINVAL) { if (!expected) { - score->pass = true; + score->score = score->total; return; } score->error @@ -111,6 +136,11 @@ static void check_has_license(struct manifest *m, return; } if (errno == ENOENT) { + /* Public domain doesn't really need a file. */ + if (m->license == LICENSE_PUBLIC_DOMAIN) { + score->score = score->total; + return; + } score->error = talloc_strdup(score, "LICENSE does not exist"); if (expected) @@ -124,11 +154,10 @@ static void check_has_license(struct manifest *m, buf[len] = '\0'; - if (!strstarts(buf, "../../licenses/")) { + if (!strstarts(buf, prefix)) { score->error = talloc_asprintf(score, - "Expected symlink to" - " ../../licenses/..." - " not %s", buf); + "Expected symlink into" + " %s not %s", prefix, buf); return; } @@ -156,3 +185,4 @@ struct ccanlint license_exists = { .check = check_has_license, .needs = "info_exists" }; +REGISTER_TEST(license_exists);